-
Notifications
You must be signed in to change notification settings - Fork 1.6k
refactor: migrate to file-scoped namespaces and remove unused global usings statements #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Copilot
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request modernizes the C# codebase by migrating from block-scoped to file-scoped namespaces and removing unused global using statements to align with C# 10+ conventions and improve code clarity.
- Converts all block-scoped namespaces (
namespace X { }) to file-scoped namespaces (namespace X;) - Removes unused global using directives across multiple files
- Updates code formatting to follow modern C# style guidelines
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DataStructures/Hashing/NumberTheory/PrimeNumber.cs | Removed unused System imports and migrated to file-scoped namespace |
| DataStructures/Hashing/Entry.cs | Removed unused System and local imports, migrated to file-scoped namespace |
| DataStructures/DisjointSet/DisjointSet.cs | Removed unused System.Collections import, migrated to file-scoped namespace |
| DataStructures/Cache/LruCache.cs | Removed unused System import |
| DataStructures/Cache/LfuCache.cs | Removed unused System import |
| Algorithms/Stack/ReverseStack.cs | Converted to file-scoped namespace |
| Algorithms/Stack/NextGreaterElement.cs | Converted to file-scoped namespace |
| Algorithms/Stack/BalancedParenthesesChecker.cs | Converted to file-scoped namespace |
| Algorithms/Sorters/Utils/GallopingStrategy.cs | Removed unused imports and converted to file-scoped namespace |
| Algorithms/Sorters/Comparison/BasicTimSorter.cs | Removed unused System.Collections import and converted to file-scoped namespace |
| Algorithms/Shufflers/RecursiveShuffler.cs | Converted to file-scoped namespace |
| Algorithms/Shufflers/NaiveShuffler.cs | Converted to file-scoped namespace |
| Algorithms/Shufflers/LINQShuffler.cs | Removed unused imports and converted to file-scoped namespace |
| Algorithms/RecommenderSystem/ISimilarityCalculator.cs | Removed unused System imports |
| Algorithms/Other/Triangulator.cs | Removed unused imports and converted to file-scoped namespace |
| Algorithms/Other/JulianEaster.cs | Removed unused System.Globalization import |
| Algorithms/Other/Geohash.cs | Removed unused imports and converted to file-scoped namespace |
| Algorithms/Other/Geofence.cs | Removed unused imports and converted to file-scoped namespace |
| Algorithms/Numeric/KrishnamurthyNumberChecker.cs | Removed unused System import |
| Algorithms/Numeric/AdditionWithoutArithmetic.cs | Removed unused System and System.Numerics imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@ ## master #521 +/- ## ========================================== - Coverage 95.19% 95.14% -0.05% ========================================== Files 272 272 Lines 10921 10921 Branches 1536 1536 ========================================== - Hits 10396 10391 -5 - Misses 400 403 +3 - Partials 125 127 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Summary of the change
This pull request contains the following changes
Issue link: #520