Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

New feature in c++ project cgpa #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 2 commits into The-Young-Programmer:main from dawitbeza:newFeature

Conversation

Copy link

@ghost ghost commented Oct 18, 2024

I have contributed to the CGPA Calculator C++ project by addressing several issues and making improvements.

Firstly, I fixed a bug related to the use of variables for array initialization, such as int name[q]. This caused the program to fail, as array sizes must be constant expressions known at compile-time. To resolve this, I replaced these statically sized arrays with dynamically sized arrays using vectors.

Secondly, I refactored the code by replacing all goto statements with while loops. The use of goto is generally discouraged in modern programming due to its impact on readability and maintainability.

Finally, and most importantly, I added a new InputValidation function. This function ensures that user inputs are validated based on specified upper and lower bounds as well as the correct data type. The program will now continue prompting the user until a valid input is entered.

@Samuel-de-Oliveira Samuel-de-Oliveira added bug Something isn't working need to be tested Need a test after merge labels Oct 18, 2024
Copy link
Collaborator

Hello Dawit, the @The-Young-Programmer is about 1 year out of Github, but him gived me access to this repository, anyway i can't accept this pull request without his permission, so let's wait for his response. 🦖

P. S. your fix looks good by the way

Copy link
Author

ghost commented Oct 19, 2024
edited by ghost
Loading

Thank you so much! I truly feel like a professional software engineer now, and I appreciate your help!

Samuel-de-Oliveira and eeee88 reacted with rocket emoji

Copy link

@dawitbeza
Can you implement this changes on my NEW Account
https://github.com/The-Young-Programer/C-CPP-Programming

I have contributed to the CGPA Calculator C++ project by addressing several issues and making improvements.

Firstly, I fixed a bug related to the use of variables for array initialization, such as int name[q]. This caused the program to fail, as array sizes must be constant expressions known at compile-time. To resolve this, I replaced these statically sized arrays with dynamically sized arrays using vectors.

Secondly, I refactored the code by replacing all goto statements with while loops. The use of goto is generally discouraged in modern programming due to its impact on readability and maintainability.

Finally, and most importantly, I added a new InputValidation function. This function ensures that user inputs are validated based on specified upper and lower bounds as well as the correct data type. The program will now continue prompting the user until a valid input is entered.

@dawitbeza
Can you implement this changes on my NEW Account
https://github.com/The-Young-Programer/C-CPP-Programming

Copy link

Hello Dawit, the @The-Young-Programmer is about 1 year out of Github, but him gived me access to this repository, anyway i can't accept this pull request without his permission, so let's wait for his response. 🦖

P. S. your fix looks good by the way

@Samuel-de-Oliveira
Thanks so much for standing by me
This is my NEW Account
https://github.com/The-Young-Programer/C-CPP-Programming

I forgot my two factor authentication in my old account 🥲

Samuel-de-Oliveira and eeee88 reacted with confused emoji

Copy link

eeee88 commented May 4, 2025

/*

@ghost ghost closed this by deleting the head repository Jul 25, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working need to be tested Need a test after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /