Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow UIView subviews to be a part of Accessibility Tree#2111

Open
patryk-sredzinski wants to merge 9 commits intoTextureGroup:master from
VamaSingapore:vama
Open

Allow UIView subviews to be a part of Accessibility Tree #2111
patryk-sredzinski wants to merge 9 commits intoTextureGroup:master from
VamaSingapore:vama

Conversation

@patryk-sredzinski
Copy link

@patryk-sredzinski patryk-sredzinski commented Jun 25, 2024

If you add views to node.view, then those views aren't visible by AccessibilityInspector. This PR allows that

Copy link

CLAassistant commented Jun 25, 2024
edited
Loading

CLA assistant check
All committers have signed the CLA.

}
}

if (modalSubnode) {
Copy link
Contributor

@rcancro rcancro Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a long complicated method. It is quite possible that in the future someone will add to it, likely at the end of the method. This early return could cause newly added logic to be skipped. To protect against that, I'd prefer you put your logic inside of an if and not early return:

if (!modalSubnode) {
 // your logic
 ....
}

}

// If a view is hidden or has an alpha of 0.0 we should not include it
if (viewIsHiddenFromAcessibility(subview)) {
Copy link
Contributor

@rcancro rcancro Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cheaper than iterating over elements and should be done first.

NSArray *subviews = view.subviews;
for (UIView *subview in subviews) {
// If a view is is already added then skip it
if ([elements containsObject:subview]) {
Copy link
Contributor

@rcancro rcancro Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are looping over subviews and elements for each subview. It would be more efficient to put the elements in a set so lookup is O(1), or use a smart diff algorithm to get only the subviews not in elements and iterate over those.

[elements containsObject:subview] is likely the most expensive operation in this loop, so it should at the very least be moved to the last possible check. e.g.,

if ((subview.isAccessibilityElement || subview.accessibilityElementCount > 0)) && ! [elements containsObject:subview]) {
 [elements addObject:subview];
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcancro rcancro rcancro left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /