-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Comments
Add missing PINRemoteImage to IGListKit pod subspecs to support image caching feature#2045
Open
MussaCharles wants to merge 3 commits intoTextureGroup:master from
Open
Conversation
@MussaCharles
MussaCharles
changed the title
(削除) Add missing PINRemoteImage to IGListKit subspecs to make working with images as smooth as in Texture. (削除ここまで)
(追記) Add missing PINRemoteImage to IGListKit pod subspecs to support image caching feature (追記ここまで)
Dec 2, 2021
GeekTree0101
GeekTree0101
approved these changes
Dec 3, 2021
...(To get updated CI fixes)
...emote-image-to-iglistkit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we opt to use IGListKit supported version of Texture we have to specify in Podfile like so: -
pod 'Texture/IGListKit'doing so will just installTexture/CoreandIGListKitwithoutPINRemoteImageunless we manually install it if we want to take advantage of image caching and other cool stuffs fromPINRemoteImage.However the behavior is different when installing Texture without IGListKit,If I specify
pod 'Texture'and run pod install it automatically downloadPINRemoteImagewithout listing it manually inPodfile.This PR makes
'Texture/IGListKit'behave the same way by automatically install PINRemoteImage without listing in manually in Podfile.I have simply added PINRemoteImage as one of the dependencies of IGListKit in /Texture.podspec
ie: (
igl.dependency 'Texture/PINRemoteImage')