-
Notifications
You must be signed in to change notification settings - Fork 9
Fix: command option keep-outdated #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valentin-claras
wants to merge
1
commit into
Tekill:master
from
valentin-claras:fix/update-keep-outdated-to-boolean-remove-outdated
Open
Fix: command option keep-outdated #6
valentin-claras
wants to merge
1
commit into
Tekill:master
from
valentin-claras:fix/update-keep-outdated-to-boolean-remove-outdated
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@valentin-claras
valentin-claras
force-pushed
the
fix/update-keep-outdated-to-boolean-remove-outdated
branch
from
September 13, 2018 13:01
e4fdcb7 to
f2b2caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Why
The option
keep-outdateddoesn't work as it is a string compared to a boolean. Whatever its value, it's not going to be strictly equal tofalse(from the command line).How
We want to keep old value by default. And by putting the option, we expect to remove them.
Since a boolean value is expected, change the option to be a boolean option (without value), with a name matching the opposite of its default behavior.