-
-
Notifications
You must be signed in to change notification settings - Fork 289
feat(sidebar): navigate search results with arrow keys and open with Enter#1359
Open
shouwang0527 wants to merge 1 commit into
Open
feat(sidebar): navigate search results with arrow keys and open with Enter #1359shouwang0527 wants to merge 1 commit into
shouwang0527 wants to merge 1 commit into
Conversation
Contributor
All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.
shouwang0527
commented
May 20, 2026
Contributor
Author
I have read the CLA Document and I hereby sign the CLA.
...Enter (TableProApp#1280) Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
@shouwang0527
shouwang0527
force-pushed
the
feat/search-arrow-key-navigation
branch
from
May 20, 2026 13:14
9422aa2 to
4a8edba
Compare
shouwang0527
commented
May 20, 2026
Contributor
Author
recheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixes #1280
Implementation
control(_:textView:doCommandBy:)toSidebarContainerViewControllerto intercept arrow keys and Enter in the nativeNSSearchFieldsidebarState.selectedTablesto move through the filtered list