Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(cli): get image repository host on login#3377

Open
olevski wants to merge 1 commit intodevelop from
3301-get-image-registry-host-on-login
Open

feat(cli): get image repository host on login #3377
olevski wants to merge 1 commit intodevelop from
3301-get-image-registry-host-on-login

Conversation

@olevski
Copy link
Member

@olevski olevski commented Mar 23, 2023

closes #3301

Should be merged only after SwissDataScienceCenter/renku-gateway#636 is merged and a new version of the gateway is released.

Copy link
Collaborator

coveralls commented Mar 24, 2023
edited
Loading

Pull Request Test Coverage Report for Build 4510044419

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+85.9%) to 85.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/login.py 6 8 75.0%
Totals Coverage Status
Change from base Build 4480159119: 85.9%
Covered Lines: 25623
Relevant Lines: 29826

💛 - Coveralls

@olevski olevski force-pushed the 3301-get-image-registry-host-on-login branch from 0fbd394 to f7fc673 Compare March 24, 2023 10:09
Copy link
Member

we should get this merged at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Panaetius Panaetius Panaetius approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get actual gitlab/registry URLs from the gateway on renku login

AltStyle によって変換されたページ (->オリジナル) /