Nice work, @literalpie! I look forward to checking this out in the next day or two. In the meantime, and for posterity, would you mind sharing a few screenshots here?

Sure, here you go!
Screen Shot 2020年08月03日 at 6 11 15 PM
Screen Shot 2020年08月03日 at 6 11 31 PM

I've added changes to make use of SPM resource bundling allowed in 5.3. It references an in-progress PR to update SwiftSyntaxHighlighter, so this should be considered WIP until at least that is merged, and probably a little longer if we want to wait before requiring 5.3.

If the update to 5.3 should be it's own PR, let me know and I can split it out, or anyone can use my changes as a starting point.

@literalpie Really nice work! Glad this is on track.

I was wondering, was omitting the color for main a deliberate decision?

screenshot-2020年10月17日-2

@kaishin There were already dark mode colors in the css file and I did not make any changes. Notice here that system-background and system-grouped-background are the same in dar mode, but different in light mode. I'm not sure what the reason for this is.

@literalpie Right, I noticed after my comment. In that case that could be changed later.

@mattt Thoughts? I can do a pass on the colors after this PR is merged if you wouldn't mind.

Matt, I've updated with support for both pre and post-5.3, the build is passing, and I have squashed my changes into one commit. I've also added logic to gracefully fall back when color-scheme queries are not supported, or when CSS custom properties are not supported.

Having made these changes, as far as I know, this is ready to merge. Let me know if you have any suggestions.

Hi @mattt I'm still interested in getting this merged. Is now a good time to rebase, or are there other changes you are planning to get done before this is merged?

I see that you've moved the CSS from being a bundled file to a string in a Swift file. Should I do something similar with the JS generated here?