-
-
Notifications
You must be signed in to change notification settings - Fork 181
rtkbase port to riscv platforms. Tested on the MilkV Duo S #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Stefal
commented
May 19, 2025
Hi @tommasopolonelli !
Thank you for your pull request.
After reading it, it looks like there are many changes not related to riscv support.
Some example:
- hard coded paths
- changes in the UM980 settings
- new default location coordinates
- commented code (maybe during your tests)
- ...
I'm sorry I can't merge as is.
Could you make new PR with only modifications needed to install RTKBase on a Riscv board, and open it on the dev branch? Please squash/rebase too, because there are a lot a files added/deleted. These files seems linked to other features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct port of rtkbase on a RISC-V based processor on the MilkV Duo S board. Tests have been made with UBlox, UM980, Mosaic, via USBs and UART.
NOTE: Merge and finetuning required to support multi-platforms on the install.sh bash. For the moment it is only tested on the MilkV Duo S.