-
Notifications
You must be signed in to change notification settings - Fork 215
Fix issue when one of a children is undefined #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly huge thanks for such amazing module!
In some edge cases (like in my own) there can be a `undefined` React child. Easy to reproduce:
```js
<ReactSortable>
{some_var ? <li>123</li> : undefined}
<li>123</li>
</ReactSortable>
```
In such case crash happen because code can't read property of undefined object.
Just check changes that I made into `react-sortable.tsx` file you will understand what I'm trying to achieve.
I also changed this line from `const item = list[index];` to `const item = list[index] || {};` , just to be sure that if list doesn't have particular index, whole code not fail.
This two changes are made to prevent edge case crashes. In my own app I spend a lot of time to find out why sometime app is crashing.
Please, please approve this pull request!
andresin87
andresin87
approved these changes
Sep 15, 2021
src/react-sortable.tsx
Outdated
@@ -110,7 +110,9 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl
const dataid = dataIdAttr || "data-id";
/* eslint-disable-next-line */
return Children.map(children as ReactElement<any>[], (child, index) => {
const item = list[index];
if (!child) return undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if child is nullish?
andresin87
andresin87
requested changes
Jan 14, 2022
andresin87
andresin87
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly huge thanks for such amazing module!
In some edge cases (like in my own) there can be a
undefinedReact child. Easy to reproduce:In such case crash happen because code can't read property of undefined object.
Just check changes that I made into
react-sortable.tsxfile you will understand what I'm trying to achieve.I also changed this line from
const item = list[index];toconst item = list[index] || {};, just to be sure that if list doesn't have particular index, whole code not fail.This two changes are made to prevent edge case crashes. In my own app I spend a lot of time to find out why sometime app is crashing.
Please, please approve this pull request!