Improvements to TextUtil - #125

Open

kaylendog wants to merge 2 commits into

master from

feat/aakatz3/bettertext

Open

Improvements to TextUtil #125
kaylendog wants to merge 2 commits into
master from
feat/aakatz3/bettertext

Conversation

@kaylendog

@kaylendog kaylendog commented Apr 19, 2021

Copy link

Copy Markdown

Collaborator

@aakatz3


 ❤ Koda

a82ee71

kaylendog

kaylendog commented

Apr 19, 2021

View reviewed changes

@kaylendog kaylendog left a comment

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly a little tired after reviewing the wrong pr for half an hour but this looks okay

common/build.gradle

// Define the map containing the tokens we want to replace

def tokensMap = [

BUILDINFO_VERSION: project.rootProject.version,

@kaylendog kaylendog Apr 19, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird formatting, but I will let it pass.

common/build.gradle

@@ -1,9 +1,26 @@

buildscript {

@kaylendog kaylendog Apr 19, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing you discussed this with @Prouser123 - gets the okay from me if he approves.

common/build.gradle Outdated

import javax.lang.model.element.Modifier

import java.text.SimpleDateFormat

task DoBuildInfo {

@kaylendog kaylendog Apr 19, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more suited to #101?

common/src/test/java/com/dumbdogdiner/stickyapi/common/util/TextUtilTest.java

@Test

void prettifyText() {

Arrays.asList(TextUtil.prettifyText("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "al;ksjfuej;iajdf;luwpqo4q394utp98&(*&)(*")).forEach(System.out::println);

@kaylendog kaylendog Apr 19, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lmao this is hot

common/build.gradle

implementation "com.google.code.gson:gson:2.8.6"

api "com.google.code.gson:gson:2.8.6"

compileOnly "com.google.code.gson:gson:2.8.6"

implementation("de.skuzzle:semantic-version:2.1.0")

@kaylendog kaylendog Apr 19, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for, aside from the blindingly obvious?

@aakatz3 aakatz3 Apr 20, 2021

Copy link

Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't compile until I did that and idk why until I funfuck gradle

@kaylendog kaylendog Apr 20, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment refers to line 40 btw - guessing it's just a semver package but worth consulting @Prouser123 about modifying the build file if you haven't already.

@aakatz3

aakatz3 commented Apr 20, 2021

Copy link

Copy Markdown

Collaborator

It's for koda

@aakatz3


 un-yatopia-ify

64fa9e8

@kaylendog

kaylendog commented Apr 20, 2021

Copy link

Copy Markdown

Collaborator Author

Yes but what does it do

@kaylendog

kaylendog commented Apr 20, 2021

Copy link

Copy Markdown

Collaborator Author

Fixes kokumaji/warrior-plugin#7

kaylendog

kaylendog commented

Apr 20, 2021

View reviewed changes

@kaylendog kaylendog left a comment

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more comments, in general, would be helpful to developers who are new to this codebase which will make it easier to maintain in the future.

common/src/main/java/com/dumbdogdiner/stickyapi/common/util/TextUtil.java

return getStringWidth(text, false);

@SuppressWarnings("UnusedReturnValue")

private static final class ChatFormatStack {

@kaylendog kaylendog Apr 20, 2021

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal comment here would be nice, just so us dumb developers can work out what it does.

@kaylendog kaylendog changed the title ~~(削除) What does this do (削除ここまで)~~ (追記) Improvements to TextUtil (追記ここまで)

Apr 20, 2021

@aakatz3

aakatz3 commented Apr 20, 2021

Copy link

Copy Markdown

Collaborator

Need to split some of the gradle stuff out, and there are more things to add to text util.

@codecov

codecov Bot commented Apr 21, 2021

Copy link

Copy Markdown

Codecov Report

Merging #125 (64fa9e8) into master (e8131f5) will increase coverage by 0.77%.
The diff coverage is 55.88%.

Impacted file tree graph

@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 34.51% 35.28% +0.77% 
==========================================
 Files 63 64 +1 
 Lines 2532 2590 +58 
 Branches 286 297 +11 
==========================================
+ Hits 874 914 +40 
- Misses 1595 1608 +13 
- Partials 63 68 +5

Impacted Files	Coverage Δ
...mmon/src/main/java/com/dumbdogdiner/BuildInfo.java	`0.00% <0.00%> (ø)`
...m/dumbdogdiner/stickyapi/common/util/TextUtil.java	`60.97% <64.40%> (+30.67%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8131f5...64fa9e8. Read the comment docs.

Labels

None yet

2 participants

@kaylendog @aakatz3

Uh oh!

Conversation

@kaylendog kaylendog commented Apr 19, 2021

Uh oh!

@kaylendog kaylendog left a comment

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

@aakatz3 aakatz3 Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

aakatz3 commented Apr 20, 2021

Uh oh!

kaylendog commented Apr 20, 2021

Uh oh!

kaylendog commented Apr 20, 2021

Uh oh!

@kaylendog kaylendog left a comment

Choose a reason for hiding this comment

Uh oh!

@kaylendog kaylendog Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

aakatz3 commented Apr 20, 2021

Uh oh!

codecov Bot commented Apr 21, 2021

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants