Skip to content

Navigation Menu

Sign in
Sign up

Math module - #108

Open
kaylendog wants to merge 40 commits into
master from
feat/skyezer/math
Open

Math module #108
kaylendog wants to merge 40 commits into
master from
feat/skyezer/math

Conversation

@kaylendog

@kaylendog kaylendog commented Mar 28, 2021

Copy link
Copy Markdown
Collaborator

Mathematics Module

See #106 for more details.

@kaylendog kaylendog self-assigned this Mar 28, 2021
kaylendog changed the base branch from master to feat/jcx/major/modules-def March 28, 2021 11:42

codecov Bot commented Mar 28, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #108 (1446c64) into master (2c8da6c) will increase coverage by 2.24%.
The diff coverage is 57.28%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 34.39% 36.64% +2.24% 
==========================================
 Files 63 79 +16 
 Lines 2532 2827 +295 
 Branches 286 318 +32 
==========================================
+ Hits 871 1036 +165 
- Misses 1597 1708 +111 
- Partials 64 83 +19
Impacted Files Coverage Δ
...mbdogdiner/stickyapi/bukkit/util/LocationUtil.java 0.00% <0.00%> (ø)
...dogdiner/stickyapi/bukkit/util/PlayerSelector.java 0.00% <0.00%> (ø)
...dogdiner/stickyapi/common/arguments/Arguments.java 0.00% <0.00%> (ø)
...m/dumbdogdiner/stickyapi/common/util/MathUtil.java 0.00% <ø> (-25.00%) ⬇️
...dumbdogdiner/stickyapi/common/util/NumberUtil.java 52.17% <ø> (ø)
...m/dumbdogdiner/stickyapi/common/util/TimeUtil.java 62.85% <0.00%> (ø)
...bdogdiner/stickyapi/math/function/CubicBezier.java 0.00% <0.00%> (ø)
...dumbdogdiner/stickyapi/math/transform/Matrix3.java 0.00% <0.00%> (ø)
.../stickyapi/math/transform/TranslationBuilder3.java 0.00% <0.00%> (ø)
...com/dumbdogdiner/stickyapi/math/vector/Vector.java 36.00% <36.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8da6c...1446c64. Read the comment docs.

@kaylendog kaylendog added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation feature New feature or request help wanted Extra attention is needed labels Mar 28, 2021
@kaylendog kaylendog linked an issue Mar 28, 2021 that may be closed by this pull request
@jcxldn jcxldn added this to the v3.0 (next) milestone Mar 29, 2021
kaylendog changed the base branch from feat/jcx/major/modules-def to master March 29, 2021 11:43
@kaylendog kaylendog linked an issue Apr 24, 2021 that may be closed by this pull request
kaylendog marked this pull request as ready for review April 24, 2021 18:50
kaylendog requested a review from a team as a code owner April 24, 2021 18:50

Copy link
Copy Markdown
Collaborator Author

Made RandomUtil more inclusive for integer methods, added RandomUtil.randomIntExclusive for exclusively exclusive exclusivity.

aakatz3 self-requested a review June 19, 2021 01:26

aakatz3 commented Jun 19, 2021

Copy link
Copy Markdown
Collaborator

If Common is going to depend on math, I would recommend making math a submodule of common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZachyFoxx ZachyFoxx ZachyFoxx approved these changes
@jcxldn jcxldn Awaiting requested review from jcxldn
@kokumaji kokumaji Awaiting requested review from kokumaji
@aakatz3 aakatz3 Awaiting requested review from aakatz3

At least 1 approving review is required to merge this pull request.

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation feature New feature or request help wanted Extra attention is needed

Projects

None yet

Milestone

v3.0 (next)

Development

Successfully merging this pull request may close these issues.

Math module Ordinal Generator

AltStyle によって変換されたページ (->オリジナル) /