-
Notifications
You must be signed in to change notification settings - Fork 545
Add macOS Intel (x64) Support for Valdi Hotreload #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
japheth-waswa
wants to merge
1
commit into
Snapchat:main
from
ValdiDeveloperAcademy:feature/intel-mac-hotreload
Open
Add macOS Intel (x64) Support for Valdi Hotreload #43
japheth-waswa
wants to merge
1
commit into
Snapchat:main
from
ValdiDeveloperAcademy:feature/intel-mac-hotreload
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full hotreload support for macOS Intel (x86_64) machines by enabling the Valdi compiler companion to load to load a native SQLite binding for intel platforms
🧠 Motivation
Valdi hotreloadpreviously failed on macOS Intel systems with:This was caused by:
This PR enables Intel developers to use Valdi without requiring ARM hardware.
🆕 Changes
compiler/companion/src/cache/SQLiteCompilationCache.tsCompiled specifically for macOS Intel using Node v22.21.1 to match Valdi's embedded Node runtime.
🔧 Build Environment Used for this PR
🔧 Build Procedure
nvm install 22.21.1 nvm use 22.21.1 git clone https://github.com/WiseLibs/better-sqlite3 cd better-sqlite3 npm install npm run build-releaseProduced file
🧪 Testing
✔ valdi hotreload works on macOS Intel
✔ Builds correctly using Bazel
✔ Local projects bootstrap and sync as expected
✔ SQLiteCompilationCache initializes successfully
📌 Compatibility
This change is:
🙌 Notes
If Valdi upgrades its embedded Node version in the future, maintainers need to rebuild both:
using the same embedded Node version & ABI.