-
Notifications
You must be signed in to change notification settings - Fork 4
fix: ignore case and spaces in Palindrome Checker #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Anamikaasinghraj
wants to merge
1
commit into
ShravanDalavi:main
from
Anamikaasinghraj:fix/palindrome-ignore-case
Open
fix: ignore case and spaces in Palindrome Checker #1
Anamikaasinghraj
wants to merge
1
commit into
ShravanDalavi:main
from
Anamikaasinghraj:fix/palindrome-ignore-case
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated palindrome_checker.py to ignore uppercase/lowercase and spaces. Now "Race Car" will correctly return True.
Great improvement! 👍 Thanks for making it more robust.
Just a couple of small fixes before I can merge:
- Replace
word
withs
in the else block. - Remove the extra
palindrome_checker()
call at the bottom (sincemain()
handles execution).
Once you update those, I’ll be happy to merge 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated palindrome_checker.py to ignore uppercase/lowercase and spaces.
Now "Race Car" will correctly return True.