Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing concurrent-ruby dependency#362

Open
anmarchenko wants to merge 1 commit intoShopify:main from
anmarchenko:anmarchenko/add_concurrent_ruby_to_dependencies
Open

Add missing concurrent-ruby dependency #362
anmarchenko wants to merge 1 commit intoShopify:main from
anmarchenko:anmarchenko/add_concurrent_ruby_to_dependencies

Conversation

@anmarchenko
Copy link
Contributor

@anmarchenko anmarchenko commented Sep 4, 2025
edited
Loading

ci-queue's recent update broke datadog-ci-rb test suite:

https://github.com/DataDog/datadog-ci-rb/actions/runs/17449737864/job/49552074849?pr=401

With the following error:

 cannot load such file -- concurrent/set
# /usr/local/bundle/gems/ci-queue-0.77.0/lib/ci/queue/static.rb:3:in '<top (required)>'
# /usr/local/bundle/gems/ci-queue-0.77.0/lib/ci/queue.rb:13:in '<top (required)>'

After PR #290 Concurrent::Set is now used, but concurrent-ruby gem is not part of runtime dependencies for ci-queue. It crashes the projects that don't depend on concurrent-ruby. This PR adds missing dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Comments

AltStyle によって変換されたページ (->オリジナル) /