-
Notifications
You must be signed in to change notification settings - Fork 15
Comments
Open
Conversation
Sh4yy
Sh4yy
reviewed
Jan 29, 2024
Owner
@Sh4yy
Sh4yy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks so much.
Could you add the new env variable to the Readme file as well please? 🙏🏻
Contributor
Author
raae
commented
Feb 2, 2024
Will do and I'll fix merge conflicts!
@raae
raae
force-pushed
the
feat/make-bucket-configurable
branch
from
February 3, 2024 08:05
dbad091 to
70fe091
Compare
Contributor
Author
It should be good to go now @Sh4yy
Contributor
Author
raae
commented
Feb 10, 2024
Any other things needed before it gets merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I imagine one would like a staging bucket, dev bucket, etc., and just in general, it would be nice to configure the bucket.