Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PriceOracle return constant price when base asset and quote asset are same#234

Open
gzliudan wants to merge 1 commit intoSetProtocol:master from
gzliudan:PriceOracle
Open

PriceOracle return constant price when base asset and quote asset are same #234
gzliudan wants to merge 1 commit intoSetProtocol:master from
gzliudan:PriceOracle

Conversation

@gzliudan
Copy link
Contributor

@gzliudan gzliudan commented Mar 26, 2022

In PriceOracle, when base asset equals quote asset, we can return 10**18 directly, no need to run other rules.

 function getPrice(address _assetOne, address _assetTwo) external view returns (uint256) {
 require(
 controller.isSystemContract(msg.sender),
 "PriceOracle.getPrice: Caller must be system contract."
 );
 if (_assetOne == _assetTwo) {
 return 10**18;
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /