Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

update issuance modules#178

Open
ncitron wants to merge 6 commits intoSetProtocol:master from
ncitron:ncitron/issuance-upgrades
Open

update issuance modules #178
ncitron wants to merge 6 commits intoSetProtocol:master from
ncitron:ncitron/issuance-upgrades

Conversation

@ncitron
Copy link
Contributor

@ncitron ncitron commented Dec 15, 2021
edited
Loading

Adds a new BasicIssuanceModuleV2 and update DebtIssuanceModule and DebtIssuanceModuleV2 to call manager pre-redeem hooks and allow managers to update these hooks.

One change that ended up propagating to SlippageIssuanceModule was that I had to set the managerIssuanceHook parameter of SetTokenRedeemed to address(0) since the hook is never called for redeem. An alternative solution I tried was to override the event in SlippageIssuanceModule to remove this parameter, which compiles correctly but hardhat seems to dislike when two events have the same name. This same issue cropped up in BasicIssuanceModule

@ncitron ncitron changed the title (削除) WIP: update issuance modules (削除ここまで) (追記) update issuance modules (追記ここまで) Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /