Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updating Nuget packages in some samples#3

Open
brgrz wants to merge 1 commit intoServiceStack:master from
brgrz:master
Open

Updating Nuget packages in some samples #3
brgrz wants to merge 1 commit intoServiceStack:master from
brgrz:master

Conversation

@brgrz
Copy link

@brgrz brgrz commented May 5, 2013

fixed two lines of code in CustomAuthenticationMvc to work with latest SS

fixed two lines of code to work with latest SS
Copy link
Member

mythz commented May 5, 2013

thx, but there's a whitespace/new-line issue that shows this pull-request has modified every file.
You might have to re-clone from master to be able to send a clean pull-request.

Copy link
Author

brgrz commented May 5, 2013

hm, here the 56 modified files are depicted fine https://github.com/mhrovatic/ServiceStack.UseCases/commit/7d961bfdddbc5c71146846106e54ff0ca8125dd8

I don't know how to do it differently. I fork a project, clone my fork with GitHub for Windows, work on it, then commit and sync. Then I did pull request from the GitHub user interface.

Copy link
Member

mythz commented May 5, 2013

If it's not already, try again with autocrlf set to off, e.g:

git config --global core.autocrlf false

If the issue still exists, can you point to the lines that have changed and I can just apply the changes on my end.

Copy link
Author

brgrz commented May 5, 2013

Demis, I ran this locally but now I don't know how to make a new commit with this setting in place and a fresh pull request. You might want to update the code yourself.

The only thing I did is update all packages besides jQuery in the Manage Nuget packages dialog window and then add

using Servicestack;

to the usings list in Account and Home controllers so that ToRequestContext() was being found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /