-
Notifications
You must be signed in to change notification settings - Fork 91
Comments
Open
Conversation
I was interested in saving my consoles, then loading them later. I got tired of copy and paste to/from files.
I was interested in saving my consoles, then loading them later. I got tired of copy and paste to/from files.
Added Save and Load functions
Added Save and Load functions
I copied the reset and created load/save.
Revert "Added Save and Load functions"
Sorry - I was travelling while you guys were talking about this. I removed the local storage requirement and gave credit to the original author. I tested and it works on Chrome and Firefox. Both browsers use the same codepath. I also tested Safari and note that the console doesn't work (the top panels don't show up. I doubt that's related to my change, but thought I would mention it.)
Collaborator
staabm
commented
Jul 13, 2015
Will give it a try tomorrow
Collaborator
staabm
commented
Jul 15, 2015
Justed tested the current version. Here is a Screenshot of how the changes look like ATM:
Feature wise:
- atm occurs a js syntax error, please fix that
SyntaxError: missing ) after argument list php-console.js:201:9
TypeError: $.console is not a function
- after fixing this error the feature itself works for me in FF41 & Chrome44
UI wise:
- the new save/load feature should be more separated from the current "reset" feature
- nit: maybe it should be named import/export instead of save/load?
- After running the script the UI gets even more crowded with the memory informatioin, see
console-export-run - When clicking "load" and the editor already contains source-code it would be good if we could add a confirm dialog before overwriting the current sources
general discussion: maybe it would make sense to export/import the file into Gists instead of local files?
Summary: the feature itself is nice, but the UI needs some polish before this can be merged.
Thanks for your work so far.
@Seldaek
Seldaek
changed the title
(削除) Fixed the issues you were talking about. (削除ここまで)
(追記) Add save/load functionality (追記ここまで)
Jan 16, 2016
Collaborator
staabm
commented
Jun 10, 2016
@lowrykun any updates on this ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the delay...