-
Notifications
You must be signed in to change notification settings - Fork 275
[NUI](Gesture) Add SourceSubType property to expose gesture input subtype#7692
Open
JoogabYun wants to merge 1 commit into
Open
[NUI](Gesture) Add SourceSubType property to expose gesture input subtype #7692JoogabYun wants to merge 1 commit into
JoogabYun wants to merge 1 commit into
Conversation
...type Expose GestureSourceSubType to C# as Gesture.SourceSubType (enum) and Gesture.SourceSubType (property), providing detailed input type info (Finger, Knuckle, Palm for touch; Trackpad, Trackball for mouse) aligned with Device::Subclass::Type values. - Add SourceSubType enum (None through VirtualMouse) to Gesture - Add read-only SourceSubType property backed by CSharp_Dali_Gesture_sourceSubType_get - Add SourceSubTypeGet() DllImport to Interop.Gesture
@JoogabYun
JoogabYun
requested review from
bshsqa,
dongsug-song and
hinohie
as code owners
June 12, 2026 01:28
@github-actions
github-actions
Bot
added
the
API13
Platform : Tizen 10.0 / TFM: net8.0-tizen10.0
label
Jun 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the SourceSubType enum and exposes it via the SourceSub property to provide detailed gesture input source subclass information. It also updates the sourceType getter to map raw values for backward compatibility. The reviewer suggests renaming the SourceSub property to SourceSubType to avoid ambiguous abbreviation and align with the enum name.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
TizenAPI-Bot
commented
Jun 12, 2026
Collaborator
Internal API Changed
Added: 17, Removed: 0, Changed: 0
Added
+ /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture::SourceSub() + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + Tizen.NUI.Gesture/SourceSubType + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Finger + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Fingernail + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::HandFlat + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::HandSide + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Knuckle + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::None + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Palm + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::PenTip + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Remocon + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Trackball + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Trackpad + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::Trackpoint + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::VirtualKeyboard + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::VirtualMouse + /// <since_tizen>none</since_tizen + [EditorBrowsable(EditorBrowsableState.Never)] + static Tizen.NUI.Gesture/SourceSubType Tizen.NUI.Gesture/SourceSubType::VirtualRemocon
hinohie
hinohie
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description of Change
Expose GestureSourceSubType to C# as Gesture.SourceSubType (enum) and Gesture.SourceSubType (property), providing detailed input type info (Finger, Knuckle, Palm for touch; Trackpad, Trackball for mouse) aligned with Device::Subclass::Type values.
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-core/+/345391
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/345392
API Changes