-
Notifications
You must be signed in to change notification settings - Fork 275
Open
Conversation
@hsgwon
hsgwon
added
ACR Required
API14
Platform : Tizen 11.0 / TFM: net8.0-tizen11.0
labels
May 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the deprecated ExtractAsync methods and their associated internal logic from the ThumbnailExtractor class. Feedback suggests cleaning up now-unused System.Threading and System.Threading.Tasks namespaces and updating the class-level <since_tizen> tag to version 6 to accurately reflect the supported API version after these removals.
TizenAPI-Bot
commented
May 4, 2026
Collaborator
Public API Changed
Please follow the ACR process for the changed API below.
Added: 0, Removed: 4, Changed: 0
Removed
- /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,System.Threading.CancellationToken) - /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size,System.Threading.CancellationToken) - /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size) - /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String)
TizenAPI-Bot
commented
May 4, 2026
Collaborator
Public API Changed
Please follow the ACR process for the changed API below.
Added: 0, Removed: 4, Changed: 0
Removed
- /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,System.Threading.CancellationToken) - /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size,System.Threading.CancellationToken) - /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size) - /// <since_tizen>4</since_tizen - [Obsolete] - static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String)
JoonghyunCho
commented
May 4, 2026
Member
🤖 [AI Review]
Reviewed — no findings.
Scope checked:
- All 170 deleted lines are 4
[Obsolete]-markedExtractAsyncoverloads plus their two private helpers (RunExtractAsync,ExtractAsyncCore) that were exclusively callers of the obsolete methods. - Verified via repo-wide search that no remaining call sites reference
ExtractAsyncoutside the modified file — removal is safe. - The
Obsoletemessage stated removal in API12; this PR removes them at API14 (labelAPI14), backed by ACRTCSACR-650. - Public surviving
Extractoverloads in the same class are unchanged in signature. - No new public APIs introduced, so no XML-doc /
since_tizenrequirements apply.
No 🔴 critical issues, no 🟡 suggestions to flag.
Automated review — final merge decision rests with human reviewers.
wiertel
wiertel
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description of Change
Remove deprecated ExtractAsync method
API Changes