Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

✨ Add apps, geo, and countries lookup commands (v5 Phase 1)#33

Merged
SamPetherbridge merged 1 commit into
main from
feat/v5-lookup-commands
Jun 9, 2026
Merged

✨ Add apps, geo, and countries lookup commands (v5 Phase 1) #33
SamPetherbridge merged 1 commit into
main from
feat/v5-lookup-commands

Conversation

@SamPetherbridge

@SamPetherbridge SamPetherbridge commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary

Phase 1 of #32 — surfaces three read-only lookup resources from the asa-api-client v5 surface that the CLI previously had no way to reach. These are the foundational lookups: you need an app's adamId to create campaigns, and geo ids to target locations.

New commands

Command Library call Purpose
asa apps search <query> [--own] [--limit] client.apps.search Find advertisable iOS apps and their adamId
asa geo search <query> --country US [--entity] [--limit] client.geo.search Find geo locations (Country/AdminArea/Locality) for targeting
asa countries list [--code US ...] client.countries_or_regions.list List supported countries/regions and their ad languages

All three support --format table\|json\|csv via the shared output_data helper and follow the existing typer/utils conventions (get_client, spinner, handle_api_error).

Verification

  • ruff check / ruff format --check
  • mypy --strict (16 source files)
  • pytest — 8 passed (added help/registration tests for the 3 new groups)
  • ✅ Help renders correctly for each command; full command tree loads

Scope

Part of #32 — does not close it. Remaining phases: creative management (ads, product-pages), reporting & billing (custom-reports, budget-orders), and org/access (acls).

Surface three read-only v5 reference resources from asa-api-client that
the CLI previously could not reach:
- asa apps search <query> — find advertisable apps and their adamId
- asa geo search <query> -c — find geo locations for campaign targeting
- asa countries list — list supported countries and ad languages
All support --format table/json/csv. Phase 1 of #32.
@SamPetherbridge SamPetherbridge added the enhancement New feature or request label Jun 9, 2026
@SamPetherbridge SamPetherbridge merged commit 9843cd9 into main Jun 9, 2026
1 check passed
@SamPetherbridge SamPetherbridge deleted the feat/v5-lookup-commands branch June 9, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /