-
Notifications
You must be signed in to change notification settings - Fork 47
Update PMDB.Create_Database_Backup.sql #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements Made: 1. Used SYSNAME instead of VARCHAR(50) for database names — it’s more semantically accurate and flexible. 2. Formatted timestamp using FORMAT() for readability. 3. Better username extraction using PARSENAME() to get only the login name. 4. Improved folder logic with fallback/default behavior. 5. Added IF NOT EXISTS to create schema safely. 6. Included WITH INIT, STATS = 10 for better control and visibility during the backup process. 7. Added error handling to notify if the DB doesn’t exist. 8. Readable and reusable variable names to make the procedure self-documenting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements Made: