SDWebImageSwiftUI/Classes/ImageManager.swift (3)

64-84: Nice containment for callback races; consider concurrent queue + barrier writes to reduce contention.

Your serial queue works; a lightweight upgrade improves read parallelism without sacrificing safety.

Apply:

- private let callbackQueue = DispatchQueue(label: "ImageManager.callbacks", qos: .userInitiated)
+ private let callbackQueue = DispatchQueue(label: "ImageManager.callbacks",
+ qos: .userInitiated,
+ attributes: .concurrent)
@@
 var successBlock: ((PlatformImage, Data?, SDImageCacheType) -> Void)? {
 get { callbackQueue.sync { _successBlock } }
- set { callbackQueue.sync { _successBlock = newValue } }
+ set { callbackQueue.sync(flags: .barrier) { _successBlock = newValue } }
 }
@@
 var failureBlock: ((Error) -> Void)? {
 get { callbackQueue.sync { _failureBlock } }
- set { callbackQueue.sync { _failureBlock = newValue } }
+ set { callbackQueue.sync(flags: .barrier) { _failureBlock = newValue } }
 }
@@
 var progressBlock: ((Int, Int) -> Void)? {
 get { callbackQueue.sync { _progressBlock } }
- set { callbackQueue.sync { _progressBlock = newValue } }
+ set { callbackQueue.sync(flags: .barrier) { _progressBlock = newValue } }
 }

---

117-123: Good: snapshot callback then hop to main. Align contract across all callbacks.

Progress is delivered on main; success/failure currently aren’t. Consider documenting or making them consistent (see next comment).

Would you like me to add doc comments clarifying callback threading guarantees?

---

135-152: Dispatch completion callbacks to main and avoid discouraged NSError() init.

Prevents UI-thread surprises and fixes SwiftLint discouraged_direct_init (hint at Line 151).

Apply:

- if let image = image {
- successCallback?(image, data, cacheType)
- } else {
- failureCallback?(error ?? NSError())
- }
+ DispatchQueue.main.async {
+ if let image = image {
+ successCallback?(image, data, cacheType)
+ } else {
+ let defaultError = NSError(
+ domain: "SDWebImageSwiftUI.ImageManager",
+ code: -1,
+ userInfo: [NSLocalizedDescriptionKey: "Image load failed with unknown error"]
+ )
+ failureCallback?(error ?? defaultError)
+ }
+ }

If existing users rely on background-thread completion, confirm before merging to avoid a breaking change. I can add a minor version note or a feature flag (e.g., deliverCompletionsOnMain).

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.