-
Notifications
You must be signed in to change notification settings - Fork 247
[Important changes]Trying to move the initial state setup before onAppear to fix the watchOS switching url or any other state issue
#316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. @alfredcc
I just remove the platform differences code, in example the issue seems disappeared. But I don't have a real world App to test.
I'll release a patch version (v3.0.4) and you can have a test with this to see the result.
...atchOS switching url or any other state issue This maybe a behavior changes, need testing
@dreampiggy
dreampiggy
force-pushed
the
try_fix_watchOS_switch_nil_url
branch
from
April 29, 2024 10:24
c5f6404 to
5f8a8ac
Compare
@dreampiggy
dreampiggy
changed the title
(削除) Trying to move the initial state setup before
(追記) [Important changes]Trying to move the initial state setup before Apr 29, 2024
onAppear to fix the watchOS switching url or any other state issue (削除ここまで)onAppear to fix the watchOS switching url or any other state issue (追記ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This maybe a behavior changes, need testing
I have no extra time to test, so just release another patch version and please test this (seems work well on example)
This close #312
This close #314
And maybe many many other issue which related to the
onAppearbehavior of SwiftUI.