-
Notifications
You must be signed in to change notification settings - Fork 326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not merge this implementation in such state.
Please, do not disable the Clippy lints, follow the trait API defined in the digest crate, keep the crate no_std-capable (i.e. your code should not have any Vecs), add a CI workflow config for this crate (you can use the md5 file for reference), add the crate to the workspace by modifying the root Cargo.toml file, and remove the md6/.gitignore file.
Our trait APIs are a bit complex (and not documented that well), so I recommend taking a look at other crates in this repository first.
truthixify
commented
Dec 29, 2024
@newpavlov
I don't know why this is failing: sha2 / riscv64-zknh (pull_request)
newpavlov
commented
Jan 3, 2025
The CI failure is fixed in #637, so you need to rebase to master.
@newpavlov
newpavlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have some surface-level comments for now. I will take a closer look at the algorithm implementation later.
added source for test vectors
newpavlov
commented
Mar 24, 2025
Could you also add this crate to the algorithms table in the root README?
newpavlov
commented
Mar 24, 2025
Also please add a CI job for this crate. You can use the md5 config for reference.
truthixify
commented
Apr 20, 2025
Hello sir @newpavlov.
I've added all the changes sir.
implementation of md6 in pure rust.