-
Notifications
You must be signed in to change notification settings - Fork 70
add spirv-unknown-naga-wgsl
target via naga
#280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
016845f
to
6696b4f
Compare
wgsl-unknown-unknown
target via naga (削除ここまで)spirv-unknown-wgsl
target via naga (追記ここまで)
ca183f5
to
7ff21a6
Compare
4235871
to
03eac2f
Compare
I think this is fine and later when we change it to have something generic like "gpu" we can document it / support the old style as well. Do you think instead it should be spirv-[unknown-]naga-wgsl
or spirv-[unknown-]wgpu-wgsl
? Probably not but wanted to check in case you hadn't thought of those options and they are more appropriate. I doubt we'd have another or "pure" wgsl backend for a long time.
I actually think we should add naga
to the target, since we could be having a *-naga-glsl
and a *-cross-glsl
target via spirv-cross
03eac2f
to
1e81bd3
Compare
1e81bd3
to
2a0dd72
Compare
2a0dd72
to
db23681
Compare
db23681
to
c3d5ffd
Compare
bede829
to
36e9997
Compare
f0aeca3
to
9943c55
Compare
spirv-unknown-wgsl
target via naga (削除ここまで)spirv-unknown-naga-wgsl
target via naga (追記ここまで)
72c8271
to
cefb504
Compare
It has been renamed to spirv-unknown-naga-wgsl
and should be quite usable already. There's still a bunch of failing compiletests due to naga not parsing some spv structure properly, they should either be ignored or checked upon before merging. May just opt for ignoring them all and fixing them up at a later date.
Nice side effect of naming it naga-wgsl
: compiletest can be ignored with ignore-naga
so any future naga targets will also be ignored.
36e9997
to
1cf4edf
Compare
63f251d
to
c2bef95
Compare
12f865c
to
0891715
Compare
c2bef95
to
84e977f
Compare
0891715
to
cc372c5
Compare
84e977f
to
7fd2ed5
Compare
cc372c5
to
f149b11
Compare
7fd2ed5
to
3ac5465
Compare
f149b11
to
84e43b8
Compare
3ac5465
to
5356738
Compare
84e43b8
to
2455116
Compare
...s or instructions
5356738
to
3f05f54
Compare
Uh oh!
There was an error while loading. Please reload this page.
Requires #309 #310 #311