Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add spirv-unknown-naga-wgsl target via naga #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Firestar99 wants to merge 6 commits into target_env_enum
base: target_env_enum
Choose a base branch
Loading
from naga

Conversation

Copy link
Member

@Firestar99 Firestar99 commented Jun 11, 2025
edited
Loading

Requires #309 #310 #311

This was referenced Jun 11, 2025
@Firestar99 Firestar99 force-pushed the naga branch 4 times, most recently from 016845f to 6696b4f Compare June 13, 2025 08:48
@Firestar99 Firestar99 changed the title (削除) add wgsl-unknown-unknown target via naga (削除ここまで) (追記) add spirv-unknown-wgsl target via naga (追記ここまで) Jun 13, 2025
@Firestar99 Firestar99 force-pushed the naga branch 9 times, most recently from ca183f5 to 7ff21a6 Compare June 16, 2025 09:49
@Firestar99 Firestar99 force-pushed the naga branch 2 times, most recently from 4235871 to 03eac2f Compare June 22, 2025 12:32
Copy link
Collaborator

LegNeato commented Jun 22, 2025
edited
Loading

I think this is fine and later when we change it to have something generic like "gpu" we can document it / support the old style as well. Do you think instead it should be spirv-[unknown-]naga-wgsl or spirv-[unknown-]wgpu-wgsl? Probably not but wanted to check in case you hadn't thought of those options and they are more appropriate. I doubt we'd have another or "pure" wgsl backend for a long time.

Firestar99 reacted with thumbs up emoji

Copy link
Member Author

I actually think we should add naga to the target, since we could be having a *-naga-glsl and a *-cross-glsl target via spirv-cross

LegNeato reacted with thumbs up emoji

@Firestar99 Firestar99 changed the base branch from main to target_env_enum July 2, 2025 08:40
@Firestar99 Firestar99 force-pushed the target_env_enum branch 2 times, most recently from bede829 to 36e9997 Compare July 11, 2025 16:31
@Firestar99 Firestar99 force-pushed the naga branch 3 times, most recently from f0aeca3 to 9943c55 Compare July 11, 2025 16:58
@Firestar99 Firestar99 changed the title (削除) add spirv-unknown-wgsl target via naga (削除ここまで) (追記) add spirv-unknown-naga-wgsl target via naga (追記ここまで) Jul 11, 2025
Copy link
Member Author

It has been renamed to spirv-unknown-naga-wgsl and should be quite usable already. There's still a bunch of failing compiletests due to naga not parsing some spv structure properly, they should either be ignored or checked upon before merging. May just opt for ignoring them all and fixing them up at a later date.

Nice side effect of naming it naga-wgsl: compiletest can be ignored with ignore-naga so any future naga targets will also be ignored.

@Firestar99 Firestar99 force-pushed the naga branch 2 times, most recently from 63f251d to c2bef95 Compare July 25, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb Awaiting requested review from eddyb eddyb will be requested when the pull request is marked ready for review eddyb is a code owner

@LegNeato LegNeato Awaiting requested review from LegNeato LegNeato will be requested when the pull request is marked ready for review LegNeato is a code owner

@schell schell Awaiting requested review from schell schell will be requested when the pull request is marked ready for review schell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /