-
Notifications
You must be signed in to change notification settings - Fork 16
fix: ensure -p package is resolved to shader crate before build and install commands are reconstructed#124
Open
fix: ensure -p package is resolved to shader crate before build and install commands are reconstructed #124
Conversation
...nstall commands are reconstructed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes ensure that the correct shader crate is used to search for metadata. Previously the install and build commands' fields were being clobbered before the resolution could happen. I've pulled up the shader crate resolution to happen at the top of the call tree, before merging arguments.