-
Notifications
You must be signed in to change notification settings - Fork 396
Open
Conversation
sampatbadhe
commented
Jan 30, 2023
Author
@EppO Could you please take a look into this PR.
thomas-mcdonald
commented
Feb 2, 2023
Member
Is it possible to add a test case for the change covering what this fixes?
...alse for custom model method names starts with is_ and ends with ?
sampatbadhe
commented
Feb 27, 2023
Author
@thomas-mcdonald I added specs and also made change to Undefine dynamic methods on removing last role, could you please take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.