Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Theme support added#23

Open
solalem wants to merge 1 commit into
RobinPerris:master from
solalem:theme_support
Open

Theme support added #23
solalem wants to merge 1 commit into
RobinPerris:master from
solalem:theme_support

Conversation

@solalem

@solalem solalem commented Jan 31, 2020

Copy link
Copy Markdown

Dark and Light themes added

ohhsodead, matte-ek, DimitarBogdanov, Nickelony, biotech7, c272, danielj23, hopla, ricardodalarme, moette, and 3 more reacted with thumbs up emoji

Copy link
Copy Markdown

Ooo very nice indeed.

Copy link
Copy Markdown

Some texts stay white and are not 100% readable but that can be fixed. This is awesome.

Copy link
Copy Markdown
Owner

I realise this is a very late comment - I've been meaning to fully review this PR for a while now but never had the time (and still do not have the time) to properly step through and test these changes.

As such, whilst I appreciate the amount of work that went in to this, I will not be merging this in.

DarkUI, .NET Framework 4.0, and WinForms are all legacy technologies at this point and should not be used when creating a brand new solution. Personally I use none of these, and no longer use Windows as my primary operating system.

Back in 2015/2016 I think this feature would have been a very strong selling point of DarkUI. However, in 2020 we're basically operating on life support. I'll continue to merge in bug fixes and minor improvements, but complete re-writes of core functionality are off the table.

I'll leave this PR open for anyone who wishes to pull down the changes made and run them locally, but I will not be deploying this to NuGet.

hopla, danielj23, ricardodalarme, vingard, moette, ohhsodead, Hi-ImKyle, FallenAvatar, nitz, ItsPepperpot, and 6 more reacted with thumbs down emoji

Copy link
Copy Markdown

... WinForms are all legacy technologies at this point and should not be used when creating a brand new solution.

Sorry about the bump, but I have to disagree with this. WinForms is still very much alive and is, in fact, seeing some love in .Net 5.0/6.0. I personally do not like XAML, so WPF and WinUI are a no-go for me.

FallenAvatar, nitz, Kawa-oneechan, ItsPepperpot, drsurfer, jmoralesv, God-damnit-all, claud84, BlueAmulet, creizlein, and ohhsodead reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /