Skip to content

Navigation Menu

Sign in
Sign up

Mention licensing information in README - #149

Open
ferki wants to merge 1 commit into
master from
license
Open

Mention licensing information in README #149
ferki wants to merge 1 commit into
master from
license

Conversation

@ferki

@ferki ferki commented Apr 12, 2020

Copy link
Copy Markdown
Member

@krimdomu @ehuelsmann: this is the licensing information we discussed earlier briefly. IANAL, but I'd like to mention it in the README.

@ehuelsmann ehuelsmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Fine by me.

Copy link
Copy Markdown
Contributor

@krimdomu ping

Copy link
Copy Markdown
Contributor

Fine for me

ferki commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

Fine for me

Thanks @krimdomu for stating your approval as a comment! Could you also approve it as a reviewer, please?

(Reasoning: it's possible to remove/edit the text of comments later, but approval seems to be logged as part of the issue history more permanently; I believe that's more formal/explicit, which feels like a better fit for the legal nature of question).

ferki commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

Based on my previous review of the repo, content by third party authors has been removed or rewritten. I believe that means if the three of us agrees on the new license, we can formally make the licensing change in order to make the contribution process smoother for future volunteers.

I'll do another review round later before merging.

Copy link
Copy Markdown
Contributor

@ferki time to close this PR?

ferki commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

@ehuelsmann: right, it wasn't merged yet, despite the initial agreement and approval, from the three of us.

My last notes about this topic say that all the previous contributors would also need to approve the license – or perhaps we can review all previous contributions, and see if we still ship them or not.

I have to admit I did not feel the motivation and capacity so far to do such a review in preparation to merge, while I still definitely would like to see a clearly applied license to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krimdomu krimdomu krimdomu approved these changes
+1 more reviewer
@ehuelsmann ehuelsmann ehuelsmann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /