-
Notifications
You must be signed in to change notification settings - Fork 214
Conversation
ferki
commented
Apr 16, 2020
I'm afraid a full fix would be more involved than forcing the operation unconditionally on a single FS interface. See my comment on the issue.
Let's discuss the desired behavior of Rex and implementation details first over there.
@ferki
ferki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on IRC, the minimum approach for this would be to:
- test for file writability in all the
Rex::Interface:Fs::*modules before having a chance to hang on an interactive prompt, and raise an exception: the built-inis_writablefunction might help here - fix all potentially affected methods: at least
unlinkwould probably be affected as well, and there might be more, likermdir
Also let's find a way to test at least a subset of those cases. Perhaps Test::Timer might help to detect hangs? Not sure how to kill the hung call though yet.
See more details on this comment.
If you'd like to keep working on this here, please mark the PR as draft, and feel free to update it as often as you need. Ideally, the first commit would be including tests that would fail, and then the follow-up commit(s) would fix that.
For #1299