Skip to content

Navigation Menu

Sign in
Sign up

Issue2608 numbers filterd by app sid - #2630

Open
otsakir wants to merge 3 commits into
master from
issue2608_numbers_filterd_by_appSid
Open

Issue2608 numbers filterd by app sid #2630
otsakir wants to merge 3 commits into
master from
issue2608_numbers_filterd_by_appSid

Conversation

@otsakir

@otsakir otsakir commented Nov 10, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

Added application-based filtering to IncomingPhoneNumber list method.The patch includes:

  • Small change in REST layer so that ApplicationSid parameter is recognized
  • Inclusion of applicationSid in IncomingPhoneNumber filter
  • Changes in mybatis descriptors. All related .xml files have been updated including mariadb and tetsts.
  • Automated tests
  • Updates in the docs

Also, a binary has been produced locally and tested manually for the new feature. Both hsql and mariadb backends were used.

This relates to #2608

Orestis Tsakiridis added 2 commits November 9, 2017 10:55
...t test and mybatis layer update (for test only)
Refers #2608 
... the codebase (tests, mysql descriptors etc.)
Refers #2608 
@ghjansen ghjansen assigned ghjansen and unassigned ghjansen Nov 14, 2017
gvagenas force-pushed the issue2608_numbers_filterd_by_appSid branch from 84bf56a to 2c853ad Compare January 13, 2022 15:28
gvagenas force-pushed the issue2608_numbers_filterd_by_appSid branch from 2c853ad to e594b09 Compare January 13, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvagenas gvagenas Awaiting requested review from gvagenas
@maria-farooq maria-farooq Awaiting requested review from maria-farooq
@abdulazizali77 abdulazizali77 Awaiting requested review from abdulazizali77

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /