-
Notifications
You must be signed in to change notification settings - Fork 233
Open
Conversation
JVGD
commented
Jun 11, 2018
Is this patch to be committed? I found the same problem on a local installation and I thought about pulling some changes but if you are not responsive then I won't collaborate
johschmitz
commented
Jun 11, 2018
Author
Wait, you are talking towards the maintainer(s) are you?
This is almost two years old but they haven't merged it... :-/
JVGD
commented
Jun 11, 2018
Yes yes, sorry for the confusion, I just stumbled into the same problem and fixed like you did. You even took the time to patch it, I was gonna do the same but then I saw they are not maintaining this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.