-
Notifications
You must be signed in to change notification settings - Fork 75
Fixes handling of applications without packages in resources #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you,
there are some cases where packages will be constructed latter, can you experiment with this one ?
put setApkFile out of if block
if(packageBlock != null) { manifestBlock.setPackageBlock(packageBlock); } manifestBlock.setApkFile(this);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ...
The purpose of ensureLoadedManifestLinked() is to check multiple times that manifest has correct package. In both cases ( pickOneOrEmpty & setApkFile) the manifest will claim having correct package even if new package is produced latter.
My other idea is :
if(packageBlock != null && !packageBlock.isEmpty()) { TableBlock linkedTable = packageBlock.getTableBlock(); if(linkedTable == tableBlock) { return; } } packageBlock = tableBlock.pickOne(manifestBlock.guessCurrentPackageId()); if(packageBlock == null) { packageBlock = tableBlock.pickOrEmptyPackage(); }
After one of the latest changes the handling of applications that don't contain packages in the .arsc file broke down:
And on build: