-
Notifications
You must be signed in to change notification settings - Fork 217
Open
Conversation
@romanbsd
romanbsd
force-pushed
the
master
branch
from
October 1, 2017 11:14
6c4e966 to
0297fe7
Compare
avishniakov
avishniakov
approved these changes
Feb 9, 2018
romanbsd
commented
Mar 29, 2018
Author
Is it going to be merged?
pmiddend
commented
Jun 2, 2018
Note that the tests don\t seem to run:
tradesim() missing 3 required positional arguments: 'alloc', 'df_historic', and 'f_start_cash'
Though I'm not sure this is your fault or if the original repo's tests don't run, either.
romanbsd
commented
Jun 6, 2018
Author
@pmiddend I'll check. How do you run the tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the QSTK for Python 3.x support. I'm using it for the coursera course. So far I hadn't had any problems.