-
Notifications
You must be signed in to change notification settings - Fork 561
[WIP] implementation of low rank ot via factor relaxation paper - #719
Open
fegounna wants to merge 10 commits into
Open
[WIP] implementation of low rank ot via factor relaxation paper #719fegounna wants to merge 10 commits into
fegounna wants to merge 10 commits into
Conversation
Codecov Report
Attention: Patch coverage is 19.35484% with 50 lines in your changes missing coverage. Please review.
Project coverage is 96.84%. Comparing base (
c128104) to head (4a44da2).
Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #719 +/- ## ========================================== - Coverage 97.08% 96.84% -0.25% ========================================== Files 100 102 +2 Lines 19947 20009 +62 ========================================== + Hits 19365 19377 +12 - Misses 582 632 +50
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
rflamary
commented
Mar 14, 2025
Collaborator
Hello,
Thanks for your PR. Things that need to be done before we do a full coder review:
- Add tests for a functions with a good coverage.
- Add examples in /examples/ folder for the documentation
- Merge your contribution wit /ot/lowrank.py en potentially factorize code/unify API
fegounna
commented
Mar 24, 2025
Author
Thanks you for your message.
I will do it next week.
cedricvincentcuaz
commented
May 18, 2025
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Types of changes
Added implementation of the paper Low-Rank Optimal Transport through Factor Relaxation with Latent Coupling
https://arxiv.org/abs/2411.10555
How has this been tested (if it applies)
Tested it on optimal transport problems and compared it with sinkhorn solver.
Tested using numpy and torch.
PR checklist