Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Add avatars (Sourcery refactored) #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orronai merged 1 commit into edit-profile from sourcery/edit-profile
Oct 10, 2021
Merged

Conversation

Copy link

@sourcery-ai sourcery-ai bot commented Oct 10, 2021

Pull Request #331 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the edit-profile branch, then run:

git fetch origin sourcery/edit-profile
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

return client.post(
f'/avatar', data={'avatar': avatar}, follow_redirects=True,
)
return client.post('/avatar', data={'avatar': avatar}, follow_redirects=True)
Copy link
Author

@sourcery-ai sourcery-ai bot Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function upload_avatar refactored with the following changes:

Copy link
Author

sourcery-ai bot commented Oct 10, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.13 ⭐ 0.13 ⭐ 0.00
Method Length 22.96 ⭐ 22.94 ⭐ -0.02 👍
Working memory 5.26 ⭐ 5.26 ⭐ 0.00
Quality 91.05% ⭐ 91.05% ⭐ 0.00%
Other metrics Before After Change
Lines 324 322 -2
Changed files Quality Before Quality After Quality Change
tests/conftest.py 91.05% ⭐ 91.05% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/conftest.py create_user 0 ⭐ 46 ⭐ 13 😞 71.93% 🙂 Extract out complex expressions
tests/conftest.py create_notification 0 ⭐ 35 ⭐ 12 😞 75.29% ⭐ Extract out complex expressions
tests/conftest.py comment 0 ⭐ 32 ⭐ 11 😞 77.52% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@orronai orronai merged commit d50bfda into edit-profile Oct 10, 2021
@orronai orronai deleted the sourcery/edit-profile branch October 10, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orronai orronai Awaiting requested review from orronai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /