Feature/gamesreleasedtoday #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Liad-n wants to merge 21 commits into PythonFreeCourse:develop

from Liad-n:feature/gamesreleasedtoday

Open

Feature/gamesreleasedtoday #334

Liad-n wants to merge 21 commits into PythonFreeCourse:develop from Liad-n:feature/gamesreleasedtoday

Conversation

Liad-n

Copy link

Contributor

@Liad-n Liad-n commented Feb 24, 2021

Added games released today functionality, currently enabled always, will be added to settings once done

Liad Noam added 8 commits

February 20, 2021 17:28


 Added game releases

ed40267


 Fixed merging conflicts

96adc87


 Partial game release form


 Fixed merging conflicts

5da84ed


 Added game release utils, added games to calendar, before pull

1a84c51


 Added annotations to game adding function, before pull

df20fbb


 Merge branch 'develop' of github.com:PythonFreeCourse/calendar into f...

47b0c86

...eature/gamesreleasedtoday
Merging develop


 Added tests to game releases, current user still doesnt work in tests

3d83e49

Gonzom

Gonzom reviewed

Feb 24, 2021

View reviewed changes

app/internal/game_releases_utils.py Outdated Show resolved Hide resolved

app/templates/partials/calendar/feature_settings/game_release_modal.html Outdated Show resolved Hide resolved

app/templates/partials/calendar/feature_settings/games_list.html Outdated Show resolved Hide resolved

Liad Noam added 5 commits

February 25, 2021 02:10


 Fixed CR comments


 Fixed merging conflicts

6b74798


 Removed is_active=True in game releases, to be added only for users

70f63a3

signed up for the service.


 changed request type in one test

6bc1251


 fixed isort confusing import condition

0c27fe5

yammesicka

yammesicka requested changes

Feb 25, 2021

View reviewed changes

Copy link

Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've added insights :)

app/templates/partials/calendar/feature_settings/games_list.html Outdated Show resolved Hide resolved

tests/test_game_releases.py Outdated Show resolved Hide resolved

app/routers/game_release_dates_service.py Outdated Show resolved Hide resolved

app/routers/game_release_dates_service.py Outdated

Comment on lines 134 to 137

current_user_settings.update(games_setting_true)

session.commit()

else:

create_model(session, UserSettings, **games_setting_true_for_model)

Copy link

Member

@yammesicka yammesicka Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use merge?

Copy link

Contributor Author

@Liad-n Liad-n Feb 26, 2021 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i did now but I can't really figure it out, it keeps creating new rows(I think it goes by primary key which is just an incremental id.
Didn't find a way to only update it without duplication other than update.
for now changed it back to update.

app/routers/game_release_dates_service.py Outdated Show resolved Hide resolved

app/templates/partials/calendar/feature_settings/game_release_modal.html Show resolved Hide resolved


 fixed more CR change requests by Yam

66f8282

@Liad-n Liad-n requested a review from yammesicka

February 26, 2021 10:36

yammesicka

yammesicka requested changes

Feb 26, 2021

View reviewed changes

app/internal/game_releases_utils.py Outdated Show resolved Hide resolved

app/internal/game_releases_utils.py Show resolved Hide resolved

app/internal/game_releases_utils.py Outdated Show resolved Hide resolved

app/routers/game_release_dates_service.py Outdated Show resolved Hide resolved

app/static/js/game_releases.js Outdated

return response.text();

})

.then(function (body) {

document.querySelector("#content-div").innerHTML = body;

Copy link

Member

@yammesicka yammesicka Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

innerText maybe?

Copy link

Contributor Author

@Liad-n Liad-n Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I'm not sure it would work here, wouldn't I be lacking formatting?

app/static/js/game_releases.js Outdated Show resolved Hide resolved

Liad Noam added 3 commits

February 26, 2021 19:01


 fixed CR change requests

28b61ba


 Merge branch 'develop' of github.com:PythonFreeCourse/calendar into f...

01cc534

...eature/gamesreleasedtoday


 fixed CR change requests

@codecov-io

Copy link

codecov-io commented Feb 26, 2021 •

edited

Loading

Codecov Report

Merging #334 (7a0af20) into develop (2199bf9) will decrease coverage by 1.25%.
The diff coverage is 88.47%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
- Coverage 95.27% 94.02% -1.26% 
===========================================
 Files 80 93 +13 
 Lines 3664 4416 +752 
===========================================
+ Hits 3491 4152 +661 
- Misses 173 264 +91

Impacted Files	Coverage Δ
app/internal/on_this_day_events.py	`90.62% <0.00%> (ø)`
app/internal/user.py	`0.00% <0.00%> (ø)`
app/routers/audio.py	`43.90% <ø> (ø)`
app/routers/export.py	`82.35% <ø> (ø)`
app/dependencies.py	`87.50% <60.00%> (-12.50%)`	⬇️
app/internal/game_releases_utils.py	`80.85% <80.85%> (ø)`
app/internal/corona_stats.py	`83.33% <83.33%> (ø)`
app/routers/settings.py	`83.33% <83.33%> (ø)`
app/internal/features.py	`84.37% <84.37%> (ø)`
app/routers/game_release_dates_service.py	`85.93% <85.93%> (ø)`
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd99fc1...7a0af20. Read the comment docs.

Liad Noam added 2 commits

March 27, 2021 13:30


 Merge branch 'develop' of github.com:PythonFreeCourse/calendar into f...

9d4239f

...eature/gamesreleasedtoday


 Fixed calendar grid test with game releases, added cached API call an...

7a0af20

...d changed requests to httpx

@Liad-n Liad-n requested a review from yammesicka

March 30, 2021 00:15

Liad Noam added 2 commits

March 30, 2021 03:29


 Fixed calendar grid test with game releases, added cached API call an...

0351e35

...d changed requests to httpx


 Added typing to util function

896fc8d

Labels

None yet

4 participants

@Liad-n @codecov-io @yammesicka @Gonzom

Feature/gamesreleasedtoday #334

Are you sure you want to change the base?

Feature/gamesreleasedtoday #334

Uh oh!

Conversation

@Liad-n Liad-n commented Feb 24, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@yammesicka yammesicka Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

@Liad-n Liad-n Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@yammesicka yammesicka Feb 26, 2021

Choose a reason for hiding this comment

Uh oh!

@Liad-n Liad-n Feb 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

@Liad-n Liad-n Feb 26, 2021 •

edited

Loading

codecov-io commented Feb 26, 2021 •

edited

Loading