Search code, repositories, users, issues, pull requests...


 Add new table out of office

07ad396

Add js file to handle the radio box
Add route to profile.py
Add modal to profile.html
Add run main for pycharm


 Change requirements

3603fc6


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

4c0ef83

...into develop


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

ab738c9

...into develop


 Merge branch 'develop' into feature/out-of-office

c67115b

and add out of office logic
add out of office to event.py


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

6758cfb

...into develop


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

d547f24

...into develop


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

b33002f

...into develop


 Merge branch 'develop' into feature/out-of-office

185d37f


 Add out of office file

7a03352


 Add out of office.py file

9ff90a7


 Check Profile.html

c4a41e3


 Fix Pylint

cea872c


 Fix Pylint

dde0739

Continue to review full report at Codecov.


 Fix Js Out of office

d52f52f

@codecov-io

Copy link

codecov-io commented Feb 16, 2021 •

edited

Loading

Codecov Report

Merging #311 (3413899) into develop (cff596e) will decrease coverage by 4.44%.
The diff coverage is 84.46%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #311 +/- ##
===========================================
- Coverage 98.77% 94.32% -4.45% 
===========================================
 Files 64 77 +13 
 Lines 2849 3417 +568 
===========================================
+ Hits 2814 3223 +409 
- Misses 35 194 +159

Impacted Files	Coverage Δ
app/database/alembic/env.py	`0.00% <0.00%> (ø)`
app/internal/celebrity.py	`100.00% <ø> (ø)`
app/internal/audio.py	`28.94% <28.94%> (ø)`
app/routers/audio.py	`43.90% <43.90%> (ø)`
app/internal/out_of_office.py	`57.57% <57.57%> (ø)`
app/routers/user.py	`80.00% <57.89%> (-11.12%)`	⬇️
app/routers/profile.py	`85.15% <67.64%> (-7.58%)`	⬇️
app/internal/event.py	`89.65% <72.72%> (-10.35%)`	⬇️
app/routers/weight.py	`81.57% <81.57%> (ø)`
app/internal/utils.py	`96.55% <85.71%> (-3.45%)`	⬇️
... and 50 more

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff596e...3413899. Read the comment docs.

YairEn and others added 3 commits

February 16, 2021 21:01


 Add js script to html

75f5b9b


 Merge branch 'develop' into feature/out-of-office

bc69873


 Fix profile.html

b0c3b22

ivarshav

ivarshav reviewed

app/internal/out_of_office.py Outdated Show resolved Hide resolved

ivarshav

ivarshav reviewed

app/internal/out_of_office.py Outdated Show resolved Hide resolved

ivarshav

ivarshav reviewed

app/database/models.py Show resolved Hide resolved

ivarshav

ivarshav reviewed

app/internal/out_of_office.py Outdated Show resolved Hide resolved

ivarshav

ivarshav reviewed

app/internal/out_of_office.py Show resolved Hide resolved

ivarshav

ivarshav reviewed

app/internal/out_of_office.py Outdated

def update_out_of_office(out_of_office_data_from_req,

out_of_office_data_from_db):

activate_out_of_office = '1'

Copy link

Contributor

@ivarshav ivarshav Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add TODO

Copy link

Contributor Author

@YairEn YairEn Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain, please :)

Copy link

Contributor

@ivarshav ivarshav Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could you please explain this line? why you set always '1'?

ivarshav

ivarshav reviewed

app/static/out_of_office/out_of_office.js Show resolved Hide resolved

ivarshav

ivarshav reviewed

app/static/out_of_office/out_of_office.js Show resolved Hide resolved

@ivarshav

Copy link

Contributor

ivarshav commented Feb 17, 2021

Great job!

PureDreamer

PureDreamer reviewed

Feb 20, 2021

Copy link

Contributor

@PureDreamer PureDreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work overall

app/internal/event.py Show resolved Hide resolved

app/internal/out_of_office.py Outdated Show resolved Hide resolved

app/internal/event.py Outdated

@@ -73,7 +73,8 @@ def find_pattern(session, event):

def get_messages(session: Session,

event: Event,

uninvited_contacts: Set[str]) -> List[str]:

uninvited_contacts: Set[str],

out_of_office_users: List[Tuple[str, str]]) -> List[str]:

Copy link

Contributor

@PureDreamer PureDreamer Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be none?

Copy link

Contributor Author

@YairEn YairEn Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what did you mean?

app/internal/out_of_office.py Outdated Show resolved Hide resolved

app/internal/out_of_office.py Show resolved Hide resolved

app/routers/profile.py Outdated Show resolved Hide resolved

app/routers/profile.py

activate_out_of_office = '1'

user = session.query(User).filter_by(id=1).first()

# TODO: Check if the user exist

Copy link

Contributor

@PureDreamer PureDreamer Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could check it with an existing function.

app/routers/profile.py Outdated Show resolved Hide resolved


 Change comments and typing , add date format function

83c7755

YairEn added 5 commits

February 23, 2021 02:07


 Merge branch 'develop' into feature/out-of-office

1989a54

And add modals to profile html


 Change user to user_db and user.id

b29196b


 Change indent to 2 spaces

a0856e2


 Remove if main

c7478a4