Search code, repositories, users, issues, pull requests...


 feature: add favorite quotes

fef70ba


 fix: fixed conflicts

da92003


 fix: fixed flake8 error

4d4ac98

PureDreamer

PureDreamer reviewed

Feb 15, 2021

Copy link

Contributor

@PureDreamer PureDreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as always, best code in the course!!

app/internal/daily_quotes.py Outdated Show resolved Hide resolved

app/main.py Outdated Show resolved Hide resolved

app/static/style.css Show resolved Hide resolved

app/templates/favorite_quotes.html Outdated Show resolved Hide resolved

tests/test_quotes.py Outdated Show resolved Hide resolved

subscorp and others added 7 commits

February 16, 2021 00:18


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

9a103e6

...into feature/favorite-quotes


 fix: fixed pytest issues

8392bb2


 a small fix

c728f0c


 fix: fixed display issue in favorite_quotes.html

f62f8d3


 fix: moved favorite quotes from navigation bar to profile

82d79fd


 fix: fixed issues according to comments

26f6a91

Continue to review full report at Codecov.


 fix: fixed conflicts

076ab07

@codecov-io

Copy link

codecov-io commented Feb 17, 2021 •

edited

Loading

Codecov Report

Merging #299 (5fd6929) into develop (f04a433) will increase coverage by 1.83%.
The diff coverage is 98.03%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #299 +/- ##
===========================================
+ Coverage 94.42% 96.25% +1.83% 
===========================================
 Files 91 92 +1 
 Lines 4236 4278 +42 
===========================================
+ Hits 4000 4118 +118 
+ Misses 236 160 -76

Impacted Files	Coverage Δ
app/main.py	`94.82% <92.30%> (-1.01%)`	⬇️
app/database/models.py	`97.51% <100.00%> (+0.04%)`	⬆️
app/internal/daily_quotes.py	`100.00% <100.00%> (ø)`
app/internal/event.py	`96.62% <100.00%> (ø)`
app/routers/favorite_quotes.py	`100.00% <100.00%> (ø)`
app/routers/audio.py	`100.00% <0.00%> (+56.09%)`	⬆️
app/internal/audio.py	`100.00% <0.00%> (+71.05%)`	⬆️

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04a433...5fd6929. Read the comment docs.

subscorp added 7 commits

February 18, 2021 05:36


 fix: fixed issues according to comments

701228e


 fix: fixed conflicts

a9fe632


 fix: fixed flake8 issues

fbe286c


 fix: fixed issue in pytest

3026dd7


 fix: a tiny improvement

2238a8d


 fix: small fix

d8ce7b5


 fix: another tiny improvement

47b0b5f

ivarshav

ivarshav reviewed

Feb 18, 2021

app/internal/daily_quotes.py Outdated Show resolved Hide resolved

ivarshav

ivarshav reviewed

Feb 18, 2021

app/main.py Outdated Show resolved Hide resolved

ivarshav

ivarshav reviewed

Feb 18, 2021

tests/quotes_fixture.py Outdated Show resolved Hide resolved

yammesicka reviewed

Feb 19, 2021

Copy link

Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start :)

app/internal/daily_quotes.py Outdated Show resolved Hide resolved

app/main.py Outdated Show resolved Hide resolved

app/templates/favorite_quotes.html Outdated Show resolved Hide resolved

app/main.py Outdated Show resolved Hide resolved

app/static/favorite_quotes.js Outdated Show resolved Hide resolved

app/static/style.css Outdated Show resolved Hide resolved

subscorp added 7 commits

February 20, 2021 02:58


 fix: fixed issues according to comments


 fix: fixed conflicts

fef81a7


 fix: fixed pytest issues

e53fab9


 fix: a small fix

fedc394


 fix: another small fix

ee7ec43


 Update: now using the new login system

c012d64


 Update: now using the new login system

ac4a818

yammesicka requested changes

Feb 25, 2021

app/internal/daily_quotes.py Outdated Show resolved Hide resolved

app/main.py Outdated Show resolved Hide resolved

app/routers/favorite_quotes.py Outdated Show resolved Hide resolved

app/static/favorite_quotes.js Outdated Show resolved Hide resolved

subscorp added 3 commits

February 25, 2021 20:36


 fix: fixed issues according to comments

0ea5847


 fix: fixed issues according to comments

9f55f15


 fix: a small, final fix

99f5e33

yammesicka requested changes

Feb 25, 2021

app/internal/daily_quotes.py Outdated Show resolved Hide resolved

app/main.py Outdated Show resolved Hide resolved

app/routers/favorite_quotes.py Outdated Show resolved Hide resolved

subscorp added 19 commits

February 25, 2021 22:23


 fix: fixed issues according to comments

c390fea


 fix: fixed merge issue :)

3e33aa2


 fix: fixed conflicts

79a8e6d


 fix: trying to fix a bug in pytest

19aae78


 fix: trying to fix the bug

c671d5f


 fix: trying to fix the bug

1e4c089


 fix: trying to fix the bug

dccf688


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

095fcea

...into feature/favorite-quotes


 trying to fix the bug

60af145


 fix: trying to fix the bug (it's only in github)

07f6cc6


 fix: trying to fix the bug (it's only in github)

970f296


 fix: trying to fix the bug

e5bcdc5


 fix: trying to fix the bug

0504e22


 fix: trying to fix the bug

12481b4


 fix: trying to fix the bug

0d4042f


 fix: trying to fix the bug

de05d1a


 fix: trying to fix the bug

4abe14d


 fix: trying to fix the bug

404e195


 fix: trying to fix the bug

23becd6

yammesicka requested changes

Feb 26, 2021

app/internal/daily_quotes.py Outdated Show resolved Hide resolved


 fix: trying to fix the bug

943162a

yammesicka requested changes

Feb 26, 2021

tests/test_quotes.py Outdated Show resolved Hide resolved

subscorp added 3 commits

February 26, 2021 18:31


 fix: trying to fix the bug

9f5244e


 Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar ...

cac2432

...into feature/favorite-quotes