-
Notifications
You must be signed in to change notification settings - Fork 218
reformat - move paragraph direction and image size from style attribute to "classic" attribute #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is OK on your side, I'd prefer not to move around attributes in places where it doesn't make a difference :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used a html parser (BeautifulSoup) to do the reformatting - there's no direct control on all the details of the generated html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add closing tags to our brs, we're on HTML5 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this behavior required?
smith-kyle
commented
Jan 31, 2024
I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/PythonFreeCourse/Notebooks/pull/39
It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.
re: #37