This repository was archived by the owner on May 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
pull request for Issue: https://github.com/chavarera/python-mini-projects/issues/82 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script to fetch IMDb rating
@ShivSt code is working
Some suggestion
- Follow PEP8 guidelines
use flake8
flake8 find_IMDb_rating.py
find_IMDb_rating.py:3:1: F401 'lxml' imported but unused
find_IMDb_rating.py:5:1: E265 block comment should start with '# '
find_IMDb_rating.py:6:6: E225 missing whitespace around operator
find_IMDb_rating.py:7:8: E225 missing whitespace around operator
find_IMDb_rating.py:8:6: E225 missing whitespace around operator
find_IMDb_rating.py:9:4: E225 missing whitespace around operator
find_IMDb_rating.py:11:2: E225 missing whitespace around operator
find_IMDb_rating.py:11:27: E262 inline comment should start with '# '
find_IMDb_rating.py:14:13: E225 missing whitespace around operator
find_IMDb_rating.py:14:25: W291 trailing whitespace
find_IMDb_rating.py:15:9: E225 missing whitespace around operator
find_IMDb_rating.py:16:15: E225 missing whitespace around operator
find_IMDb_rating.py:17:1: W293 blank line contains whitespace
find_IMDb_rating.py:19:13: E225 missing whitespace around operator
find_IMDb_rating.py:20:13: E225 missing whitespace around operator
find_IMDb_rating.py:20:80: E501 line too long (94 > 79 characters)
find_IMDb_rating.py:23:19: E225 missing whitespace around operator
find_IMDb_rating.py:23:80: E501 line too long (95 > 79 characters)
find_IMDb_rating.py:25:1: E722 do not use bare except'
sure.. will streamline the code as per the guidelines.
Hi Ravi,
check now I have updated the script confirmed with flake8.
You can close the issue now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script to fetch IMDb rating