This repository was archived by the owner on May 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Game 2048 #460
Open
Open
Game 2048 #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YahelB05
commented
Sep 25, 2021
Hello @Jamyw7g !
I like to see your code improvements, but I'm missing some in-code function documentation and python conventions.
How to improve:
- Space up the functions from each other by 2 blank lines
- Document every needed function using 'docstring'
- Make sure you follow the rest of python PEP rules
How it would make it better:
- More readable
- Easy for others to be able to understand the code and help/contribute
Good Luck, Happy Coding 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A game written in Python without any Third-party Package.
Replace
issue_no
in the above line, with the issue related to this PR.Type of change
Choosing one or more options from the following as per the nature of your Pull request.
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md
)README.md
, according to the givenREADME_TEMPLATE.