Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Sript_to_reduce_img_size #240

Merged

Conversation

Copy link
Contributor

@VIPverma01 VIPverma01 commented Sep 13, 2020 •
edited
Loading

Description

A short summary of what is included in your Pull Request.

Fixes #(issue_no)

Replace issue_no in the above line, with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Contributor Author

It,s done. Please check the script and if there is any change you need then please tell me.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VIPverma01

Good work!

  • Edit your README.md according to this README TEMPLATE.
  • Could you comment on your code for a better understanding, for the ones who will be seeing your projects?
  • Avoid extra lines.
  • Validate your code with PEP8 standards:
    Check PEP8 Validation - (Python Enhancement Proposals) set some guidelines while writing your code.
pip install flake8
flake8 file_name.py

Thank you,
Tushar Nankani

Copy link
Contributor Author

I have updated the script and README as per your instructions. Please check and verify the project.
tusharnankani and chavarera reacted with thumbs up emoji VIPverma01 reacted with laugh emoji

@AdityaJ7 AdityaJ7 merged commit d819e9d into Python-World:master Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@chavarera chavarera chavarera approved these changes

@tusharnankani tusharnankani tusharnankani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /