Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Movie information scrapper #223

Merged
tusharnankani merged 4 commits into Python-World:master from anandhakrishnanaji:movie_information_scrapper
Sep 11, 2020
Merged

Movie information scrapper #223

tusharnankani merged 4 commits into Python-World:master from anandhakrishnanaji:movie_information_scrapper
Sep 11, 2020

Conversation

Copy link
Contributor

@anandhakrishnanaji anandhakrishnanaji commented Sep 10, 2020

Description

I have created python script that scrapes information about the movie name inputted from IMDB Website

Fixes #185

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Follow PEP-8 guidelines and check code linting with flake8

pip install flake8
flake8 movieInfoScrapper.py

  1. Check the name of the script in README file

  2. Code works well if all the information about a movie is present on IMDB but that is not the case all the time, adjust the script to handle exceptions, you can use: try and except block for that

  3. I am attaching a screenshot of where an exception occurred. Happens mostly when we check a yet to be released movie

bug

Copy link
Member

@tusharnankani tusharnankani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anandhakrishnanaji
Screenshot (432)
I am facing similar errors, please enhance your code using error handling. And, all the changes @AdityaJ7 requested.

  • Use try and except wherever required, to take care of all possible user inputs.

Copy link
Contributor Author

Ok will do @tusharnankani

Copy link
Member

Nice Job @anandhakrishnanaji

anandhakrishnanaji reacted with thumbs up emoji

@tusharnankani tusharnankani merged commit 43236eb into Python-World:master Sep 11, 2020
@anandhakrishnanaji anandhakrishnanaji deleted the movie_information_scrapper branch September 11, 2020 04:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@chavarera chavarera chavarera approved these changes

@AdityaJ7 AdityaJ7 AdityaJ7 approved these changes

@tusharnankani tusharnankani tusharnankani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Movie Information Scrapper

AltStyle によって変換されたページ (->オリジナル) /