Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Converts Jpeg to png #218

Merged
tusharnankani merged 2 commits into Python-World:master from AnuragGupta806:JPEG_to_PNG
Sep 9, 2020
Merged

Conversation

Copy link
Contributor

@AnuragGupta806 AnuragGupta806 commented Sep 9, 2020 •
edited
Loading

Description

This PR contains two python scripts , each having different method of changing JPEG to PNG

Fixes #215

Replace issue_no in the above line, with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnuragGupta806

  • Could you comment on your code?
  • Avoid extra lines.
  • Validate your code with PEP8 standards:
    Check PEP8 Validation - (Python Enhancement Proposals) set some guidelines while writing your code.
pip install flake8
flake8 file_name.py

Thanks,
Tushar Nankani

Copy link
Contributor Author

ok, i'll do it

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnuragGupta806!
The script works well! 👍🏻
Great thought on creating a GUI! 👏🏻

Could you disable the Convert JPEG to PNG if no file is uploaded? Since it gives this error. Or could you give a pop up: no file is selected?

Screenshot (410)

Let me know if these changes are possible!

Copy link
Contributor Author

I added an error message box and commented the code and validated using PEP8, but one error was left, which was length of line >79, i cannot do anything about it
tusharnankani reacted with thumbs up emoji

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chavarera reacted with thumbs up emoji
@tusharnankani tusharnankani merged commit 2c8377a into Python-World:master Sep 9, 2020
@AnuragGupta806 AnuragGupta806 deleted the JPEG_to_PNG branch September 9, 2020 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@chavarera chavarera chavarera approved these changes

@AdityaJ7 AdityaJ7 AdityaJ7 approved these changes

@tusharnankani tusharnankani tusharnankani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert JPEG file to PNG

AltStyle によって変換されたページ (->オリジナル) /