-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Added the project for the issue #198 #205
Conversation
@leader2one LGTM, Awesome Job. You can also add the number of guesses it took the user to win and increase the range of numbers to make it more challenging, eg:1 to 100.
@leader2one LGTM, Awesome Job. You can also add the number of guesses it took the user to win and increase the range of numbers to make it more challenging, eg:1 to 100.
thanks. Also I placed an example working screenshot in readme file. Is image being showed ?
@leader2one LGTM, Awesome Job. You can also add the number of guesses it took the user to win and increase the range of numbers to make it more challenging, eg:1 to 100.
thanks. Also I placed an example working screenshot in readme file. Is image being showed ?
No, it wasn't showing But I fixed it.
some changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes! Keep it up! @leader2one 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validate your code with PEP8 standards
Check PEP8 Validation
flake8 main.py
Suggestions:
main.py:1:14: W291 trailing whitespace
main.py:2:1: W293 blank line contains whitespace
main.py:3:30: W291 trailing whitespace
main.py:4:1: W293 blank line contains whitespace
main.py:5:35: W291 trailing whitespace
main.py:6:27: W291 trailing whitespace
main.py:7:30: W291 trailing whitespace
main.py:8:1: W293 blank line contains whitespace
main.py:9:32: W291 trailing whitespace
main.py:10:34: W291 trailing whitespace
main.py:11:36: W291 trailing whitespace
main.py:12:32: W291 trailing whitespace
main.py:13:16: W291 trailing whitespace
main.py:15:1: W293 blank line contains whitespace
main.py:16:43: W291 trailing whitespace
main.py:17:1: W293 blank line contains whitespace
main.py:18:33: W291 trailing whitespace
main.py:19:13: W291 trailing whitespace
main.py:21:1: W293 blank line contains whitespace
main.py:22:36: W291 trailing whitespace
main.py:23:25: W291 trailing whitespace
main.py:24:1: W293 blank line contains whitespace
main.py:25:38: W291 trailing whitespace
main.py:26:36: W291 trailing whitespace
main.py:27:24: W291 trailing whitespace
main.py:28:1: W293 blank line contains whitespace
main.py:29:36: W291 trailing whitespace
main.py:30:35: W291 trailing whitespace
main.py:31:42: W291 trailing whitespace
main.py:32:37: W291 trailing whitespace
main.py:33:36: W291 trailing whitespace
main.py:34:80: E501 line too long (94 > 79 characters)
main.py:35:9: E265 block comment should start with '# '
main.py:37:1: W293 blank line contains whitespace
main.py:38:32: W291 trailing whitespace
main.py:39:29: W291 trailing whitespace
main.py:40:27: W291 trailing whitespace
main.py:41:25: W291 trailing whitespace
main.py:42:75: W291 trailing whitespace
main.py:43:1: W293 blank line contains whitespace
main.py:44:33: W291 trailing whitespace
main.py:45:33: W291 trailing whitespace
main.py:46:13: W291 trailing whitespace
main.py:47:10: W291 trailing whitespace
main.py:48:75: W291 trailing whitespace
main.py:49:1: W293 blank line contains whitespace
main.py:50:40: W291 trailing whitespace
main.py:52:1: W391 blank line at end of file
validate your code with PEP8 standards
Check PEP8 Validation
flake8 main.pySuggestions:
main.py:1:14: W291 trailing whitespace main.py:2:1: W293 blank line contains whitespace main.py:3:30: W291 trailing whitespace main.py:4:1: W293 blank line contains whitespace main.py:5:35: W291 trailing whitespace main.py:6:27: W291 trailing whitespace main.py:7:30: W291 trailing whitespace main.py:8:1: W293 blank line contains whitespace main.py:9:32: W291 trailing whitespace main.py:10:34: W291 trailing whitespace main.py:11:36: W291 trailing whitespace main.py:12:32: W291 trailing whitespace main.py:13:16: W291 trailing whitespace main.py:15:1: W293 blank line contains whitespace main.py:16:43: W291 trailing whitespace main.py:17:1: W293 blank line contains whitespace main.py:18:33: W291 trailing whitespace main.py:19:13: W291 trailing whitespace main.py:21:1: W293 blank line contains whitespace main.py:22:36: W291 trailing whitespace main.py:23:25: W291 trailing whitespace main.py:24:1: W293 blank line contains whitespace main.py:25:38: W291 trailing whitespace main.py:26:36: W291 trailing whitespace main.py:27:24: W291 trailing whitespace main.py:28:1: W293 blank line contains whitespace main.py:29:36: W291 trailing whitespace main.py:30:35: W291 trailing whitespace main.py:31:42: W291 trailing whitespace main.py:32:37: W291 trailing whitespace main.py:33:36: W291 trailing whitespace main.py:34:80: E501 line too long (94 > 79 characters) main.py:35:9: E265 block comment should start with '# ' main.py:37:1: W293 blank line contains whitespace main.py:38:32: W291 trailing whitespace main.py:39:29: W291 trailing whitespace main.py:40:27: W291 trailing whitespace main.py:41:25: W291 trailing whitespace main.py:42:75: W291 trailing whitespace main.py:43:1: W293 blank line contains whitespace main.py:44:33: W291 trailing whitespace main.py:45:33: W291 trailing whitespace main.py:46:13: W291 trailing whitespace main.py:47:10: W291 trailing whitespace main.py:48:75: W291 trailing whitespace main.py:49:1: W293 blank line contains whitespace main.py:50:40: W291 trailing whitespace main.py:52:1: W391 blank line at end of file
sorry i do not understand. can you clearify more? or give hint?
validate your code with PEP8 standards
Check PEP8 Validation
flake8 main.py
Suggestions:main.py:1:14: W291 trailing whitespace main.py:2:1: W293 blank line contains whitespace main.py:3:30: W291 trailing whitespace main.py:4:1: W293 blank line contains whitespace main.py:5:35: W291 trailing whitespace main.py:6:27: W291 trailing whitespace main.py:7:30: W291 trailing whitespace main.py:8:1: W293 blank line contains whitespace main.py:9:32: W291 trailing whitespace main.py:10:34: W291 trailing whitespace main.py:11:36: W291 trailing whitespace main.py:12:32: W291 trailing whitespace main.py:13:16: W291 trailing whitespace main.py:15:1: W293 blank line contains whitespace main.py:16:43: W291 trailing whitespace main.py:17:1: W293 blank line contains whitespace main.py:18:33: W291 trailing whitespace main.py:19:13: W291 trailing whitespace main.py:21:1: W293 blank line contains whitespace main.py:22:36: W291 trailing whitespace main.py:23:25: W291 trailing whitespace main.py:24:1: W293 blank line contains whitespace main.py:25:38: W291 trailing whitespace main.py:26:36: W291 trailing whitespace main.py:27:24: W291 trailing whitespace main.py:28:1: W293 blank line contains whitespace main.py:29:36: W291 trailing whitespace main.py:30:35: W291 trailing whitespace main.py:31:42: W291 trailing whitespace main.py:32:37: W291 trailing whitespace main.py:33:36: W291 trailing whitespace main.py:34:80: E501 line too long (94 > 79 characters) main.py:35:9: E265 block comment should start with '# ' main.py:37:1: W293 blank line contains whitespace main.py:38:32: W291 trailing whitespace main.py:39:29: W291 trailing whitespace main.py:40:27: W291 trailing whitespace main.py:41:25: W291 trailing whitespace main.py:42:75: W291 trailing whitespace main.py:43:1: W293 blank line contains whitespace main.py:44:33: W291 trailing whitespace main.py:45:33: W291 trailing whitespace main.py:46:13: W291 trailing whitespace main.py:47:10: W291 trailing whitespace main.py:48:75: W291 trailing whitespace main.py:49:1: W293 blank line contains whitespace main.py:50:40: W291 trailing whitespace main.py:52:1: W391 blank line at end of filesorry i do not understand. can you clearify more? or give hint?
ok @leader2one PEP8(Python Enhancement Proposals) set some guideline while writing your code.
these guideline are the set of rules to follow while coding
style guide lines to write python code read more here..
flake8 is an external module helps to identify and validate these set of rules
Install flake8
pip install flake8
Run flake8
flake8 main.py
validate your code with PEP8 standards
Check PEP8 Validation
flake8 main.py
Suggestions:main.py:1:14: W291 trailing whitespace main.py:2:1: W293 blank line contains whitespace main.py:3:30: W291 trailing whitespace main.py:4:1: W293 blank line contains whitespace main.py:5:35: W291 trailing whitespace main.py:6:27: W291 trailing whitespace main.py:7:30: W291 trailing whitespace main.py:8:1: W293 blank line contains whitespace main.py:9:32: W291 trailing whitespace main.py:10:34: W291 trailing whitespace main.py:11:36: W291 trailing whitespace main.py:12:32: W291 trailing whitespace main.py:13:16: W291 trailing whitespace main.py:15:1: W293 blank line contains whitespace main.py:16:43: W291 trailing whitespace main.py:17:1: W293 blank line contains whitespace main.py:18:33: W291 trailing whitespace main.py:19:13: W291 trailing whitespace main.py:21:1: W293 blank line contains whitespace main.py:22:36: W291 trailing whitespace main.py:23:25: W291 trailing whitespace main.py:24:1: W293 blank line contains whitespace main.py:25:38: W291 trailing whitespace main.py:26:36: W291 trailing whitespace main.py:27:24: W291 trailing whitespace main.py:28:1: W293 blank line contains whitespace main.py:29:36: W291 trailing whitespace main.py:30:35: W291 trailing whitespace main.py:31:42: W291 trailing whitespace main.py:32:37: W291 trailing whitespace main.py:33:36: W291 trailing whitespace main.py:34:80: E501 line too long (94 > 79 characters) main.py:35:9: E265 block comment should start with '# ' main.py:37:1: W293 blank line contains whitespace main.py:38:32: W291 trailing whitespace main.py:39:29: W291 trailing whitespace main.py:40:27: W291 trailing whitespace main.py:41:25: W291 trailing whitespace main.py:42:75: W291 trailing whitespace main.py:43:1: W293 blank line contains whitespace main.py:44:33: W291 trailing whitespace main.py:45:33: W291 trailing whitespace main.py:46:13: W291 trailing whitespace main.py:47:10: W291 trailing whitespace main.py:48:75: W291 trailing whitespace main.py:49:1: W293 blank line contains whitespace main.py:50:40: W291 trailing whitespace main.py:52:1: W391 blank line at end of filesorry i do not understand. can you clearify more? or give hint?
ok @leader2one PEP8(Python Enhancement Proposals) set some guideline while writing your code.
these guideline are the set of rules to follow while codingstyle guide lines to write python code read more here..
flake8 is an external module helps to identify and validate these set of rulesInstall flake8
pip install flake8Run flake8
flake8 main.py
ok i know what pep8 is. but i am thinking about what to do with flake8 main.py. If i run this locally, there will be no change in the code in this repo. What exacty i should do right now? thanks for supporting
validate your code with PEP8 standards
Check PEP8 Validation
flake8 main.py
Suggestions:main.py:1:14: W291 trailing whitespace main.py:2:1: W293 blank line contains whitespace main.py:3:30: W291 trailing whitespace main.py:4:1: W293 blank line contains whitespace main.py:5:35: W291 trailing whitespace main.py:6:27: W291 trailing whitespace main.py:7:30: W291 trailing whitespace main.py:8:1: W293 blank line contains whitespace main.py:9:32: W291 trailing whitespace main.py:10:34: W291 trailing whitespace main.py:11:36: W291 trailing whitespace main.py:12:32: W291 trailing whitespace main.py:13:16: W291 trailing whitespace main.py:15:1: W293 blank line contains whitespace main.py:16:43: W291 trailing whitespace main.py:17:1: W293 blank line contains whitespace main.py:18:33: W291 trailing whitespace main.py:19:13: W291 trailing whitespace main.py:21:1: W293 blank line contains whitespace main.py:22:36: W291 trailing whitespace main.py:23:25: W291 trailing whitespace main.py:24:1: W293 blank line contains whitespace main.py:25:38: W291 trailing whitespace main.py:26:36: W291 trailing whitespace main.py:27:24: W291 trailing whitespace main.py:28:1: W293 blank line contains whitespace main.py:29:36: W291 trailing whitespace main.py:30:35: W291 trailing whitespace main.py:31:42: W291 trailing whitespace main.py:32:37: W291 trailing whitespace main.py:33:36: W291 trailing whitespace main.py:34:80: E501 line too long (94 > 79 characters) main.py:35:9: E265 block comment should start with '# ' main.py:37:1: W293 blank line contains whitespace main.py:38:32: W291 trailing whitespace main.py:39:29: W291 trailing whitespace main.py:40:27: W291 trailing whitespace main.py:41:25: W291 trailing whitespace main.py:42:75: W291 trailing whitespace main.py:43:1: W293 blank line contains whitespace main.py:44:33: W291 trailing whitespace main.py:45:33: W291 trailing whitespace main.py:46:13: W291 trailing whitespace main.py:47:10: W291 trailing whitespace main.py:48:75: W291 trailing whitespace main.py:49:1: W293 blank line contains whitespace main.py:50:40: W291 trailing whitespace main.py:52:1: W391 blank line at end of filesorry i do not understand. can you clearify more? or give hint?
ok @leader2one PEP8(Python Enhancement Proposals) set some guideline while writing your code.
these guideline are the set of rules to follow while codingstyle guide lines to write python code read more here..
flake8 is an external module helps to identify and validate these set of rulesInstall flake8
pip install flake8Run flake8
flake8 main.py
ok gimme a time i 'll solve this issue in the least time
here will be no change in th
ok 👍
First validate your code in your local
sync the main repository
commit your changes in local
then push your code to forked repo
and update your PR
here will be no change in th
ok 👍
First validate your code in your local sync the main repository commit your changes in local then push your code to forked repo and update your PR
thanks man. Today i learned good stuffs because of you. I solved this issue with autopep8 . You may check the updated version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fixed now, good job !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go @leader2one
Uh oh!
There was an error while loading. Please reload this page.
Description
Number Guessing Game
Fixes #198
Type of change
Checklist:
Please tick all the boxes that are fulfilled by your Pull request
I have named my files and folder according to this project's guidelines
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have created a helpful and easy to understand
README.mdI have included a requirements.txt file(if external libraries are required)
My changes dont produce any warnings.
I have added a working sample/screenshot of the script