Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Added a LOAN prediction project using python with jupyter based on Da... #201

Merged
AdityaJ7 merged 3 commits into Python-World:master from Tomyzon1728:master
Sep 8, 2020
Merged

Conversation

Copy link
Contributor

@Tomyzon1728 Tomyzon1728 commented Sep 8, 2020
edited
Loading

...ta Analysis

Description

A short summary of what is included in your pull request

Fixes #(issue_no)

Replace issue_no in the above line with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull request

  • I have named my files and folder according to this project's guidelines
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have included a requirements.txt file(if external libraries are required)
  • My changes dont produce any warnings.
  • I have added a working sample/screenshot of the script

Copy link
Contributor Author

Added aLoan Prediction Project

Copy link
Member

AdityaJ7 commented Sep 8, 2020
edited
Loading

@Tomyzon1728 Please share a google colab link to your jupyter notebook so that we can review it easily and also include the dataset that you have used in the notebook. It is hard to review jupyter notebooks without the above things. Thanks for the contribution.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tomyzon1728

Could you describe the project? And what it does?

Copy link
Contributor Author

Ok will do that 👍

@AdityaJ7 AdityaJ7 self-requested a review September 8, 2020 10:05
Copy link
Member

@AdityaJ7 AdityaJ7 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now just do one thing: Change the name of the folder name from LOAN to Customer Loan Repayment Problem and move this folder from projects to the Notebooks folder.

tusharnankani reacted with thumbs up emoji
Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tomyzon1728

Could you do what @AdityaJ7 suggested?

  • Add a folder, with an appropriate name, to the Notebooks
  • That folder should consist of an .ipynb and .csv file.
  • Commit the changes and we'll merge it! 👍🏻

Copy link
Contributor Author

Predicting Loan Repayment¶
The dataset for this project is retrieved from kaggle, the home of Data Science.

The major aim of this project is to predict whether the customers will have their loan paid or not. Therefore, this is a supervised classification problem to be trained.

http://localhost:8888/notebooks/python%20codes/python-mini-projects/projects/LOAN/loan-prediction-problem.ipynb

Also added dataset as requested

Copy link
Contributor Author

@AdityaJ7 I've done all requested of me.

Copy link
Contributor Author

Will change the name and location right away

Copy link
Contributor Author

I've changed the name, but couldn't change location because I don't have the Notebook folder . It wasn't there when I forked the code from @chavarera

AdityaJ7 reacted with thumbs up emoji

Copy link
Member

AdityaJ7 commented Sep 8, 2020
edited
Loading

I've changed the name, but couldn't change location because I don't have the Notebook folder . It wasn't there when I forked the code from @chavarera

Ok no problem i will add it to the folder @tusharnankani please approve his changes so we can merge, i will add it to the notebooks folder if he is facing issue

Copy link
Contributor Author

Alright. Will be looking forward to that

@AdityaJ7 AdityaJ7 merged commit e15ec16 into Python-World:master Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@AdityaJ7 AdityaJ7 AdityaJ7 approved these changes

@tusharnankani tusharnankani tusharnankani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /